Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #59428

Closed
wants to merge 50 commits into from
Closed

Rollup of 12 pull requests #59428

wants to merge 50 commits into from

Commits on Mar 18, 2019

  1. promoted is still left in 2 places

    Saleem Jaffer committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    7fb1c22 View commit details
    Browse the repository at this point in the history
  2. cleaner code as per review

    Saleem Jaffer committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    a837b8a View commit details
    Browse the repository at this point in the history
  3. fixed all compilation errors

    Saleem Jaffer committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    23c87a1 View commit details
    Browse the repository at this point in the history
  4. adjust MaybeUninit API to discussions

    uninitialized -> uninit
    into_initialized -> assume_init
    read_initialized -> read
    set -> write
    RalfJung committed Mar 18, 2019
    Configuration menu
    Copy the full SHA
    ac6ab65 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2019

  1. tidy checks

    Saleem Jaffer committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    776407e View commit details
    Browse the repository at this point in the history
  2. fix some uses I missed

    RalfJung committed Mar 19, 2019
    Configuration menu
    Copy the full SHA
    9374efa View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2019

  1. remove visit_static from librustc::mir

    Saleem Jaffer committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    8829dda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72f8d4e View commit details
    Browse the repository at this point in the history
  3. Allow itertools

    Zoxc committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    b440041 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d060e7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    52374a6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4d0a1e4 View commit details
    Browse the repository at this point in the history
  7. Fix whitespace

    Zoxc committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    75677c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2019

  1. Update build instructions in README.md

    Add additional instructions when `sudo ./x.py install` fails to
    complete the build.
    
    This resolves issues rust-lang#40108 and rust-lang#49269.
    ewk committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    71dfb01 View commit details
    Browse the repository at this point in the history
  2. review fixes

    Saleem Jaffer committed Mar 21, 2019
    Configuration menu
    Copy the full SHA
    cf2f1bb View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2019

  1. Configuration menu
    Copy the full SHA
    48af718 View commit details
    Browse the repository at this point in the history
  2. Expand impl FromIterator for Result doc to include examples of `Err…

    …` and early termination.
    pnkfelix committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    d5a61c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b34a71b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    37cfeb2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d56b1fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1ccad16 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2019

  1. Configuration menu
    Copy the full SHA
    8ba1a97 View commit details
    Browse the repository at this point in the history
  2. Tweak labels

    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    b1a6c32 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    72a3089 View commit details
    Browse the repository at this point in the history
  4. Hide "type ascription is experimental error" unless it's the only one

    In order to minimize the verbosity of common syntax errors that are parsed
    as type ascription, hide the feature gate error unless there are no other
    errors being emitted by the parser.
    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    81b876b View commit details
    Browse the repository at this point in the history
  5. Review comment

    estebank committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    44a086e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d72ef21 View commit details
    Browse the repository at this point in the history
  7. adding mir::StaticKind enum for static and promoted

    Saleem Jaffer committed Mar 23, 2019
    Configuration menu
    Copy the full SHA
    752544b View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2019

  1. code review fixes

    Saleem Jaffer committed Mar 24, 2019
    Configuration menu
    Copy the full SHA
    fb93f10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d7c2bb View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2019

  1. Moves test::black_box to core::hint

    This changes removes a cyclic dependency between the "test" and "libtest"
    crates, where "libtest" depends on "test" for "black_box", but "test" depends on
    "libtest" for everything else.
    
    I've chosen the "hint" module because there seems to be enough consensus in the
    discussion of RFC2360 that this module is where such an intrinsic would belong,
    but this PR does not implement that RFC! (note: if that RFC ever gets merged,
    the API, docs, etc. of this API will need to change).
    
    For backwards compatibility reasons I've chosen to also keep the "test" feature
    gate for these instead of adding a new feature gate. If we change the feature
    gate, we'll potentially all benchmarks, and while that's something that we could
    do, it seems unnecessary to do that now - if RFC2360 gets merged, we'll need to
    do that anyways.
    gnzlbg committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    f5d6b3a View commit details
    Browse the repository at this point in the history
  2. Remove dupplicated config

    gnzlbg committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    f244383 View commit details
    Browse the repository at this point in the history
  3. Update src/libcore/option.rs

    Co-Authored-By: pnkfelix <pnkfelix@pnkfx.org>
    killercup and pnkfelix committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    6315221 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cfa76c4 View commit details
    Browse the repository at this point in the history
  5. add missing braces

    add missing braces analogous to those suggested by killercup
    pnkfelix committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    0e83e96 View commit details
    Browse the repository at this point in the history
  6. Clarify {Ord,f32,f64}::clamp docs a little

    Explicitly call out when it returns NaN, adhere to the panic doc
    guidelines.
    tbu- committed Mar 25, 2019
    Configuration menu
    Copy the full SHA
    0bb36a2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    24db517 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    28c602a View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Rollup merge of rust-lang#59150 - estebank:type-ascription, r=varkor

    Expand suggestions for type ascription parse errors
    
    Fix rust-lang#51222. CC rust-lang#48016, rust-lang#47666, rust-lang#54516, rust-lang#34255.
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    3e7a5fd View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#59232 - saleemjaffer:mir_place_refactor, r=…

    …oli-obk
    
    Merge `Promoted` and `Static` in `mir::Place`
    
    fixes rust-lang#53848
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    01af178 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#59284 - RalfJung:maybe-uninit, r=sfackler

    adjust MaybeUninit API to discussions
    
    uninitialized -> uninit
    into_initialized -> assume_init
    read_initialized -> read
    set -> write
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    e061309 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#59315 - Zoxc:move-query, r=oli-obk

    Add no_hash to query macro and move some queries over
    
    r? @oli-obk
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    205d20a View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#59334 - ewk:readme, r=Mark-Simulacrum

    Update build instructions in README.md
    
    Add additional instructions when `sudo ./x.py install` fails to
    complete the build.
    
    This resolves issues rust-lang#40108 and rust-lang#49269.
    
    r? @steveklabnik
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    7b70515 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#59336 - gnzlbg:hint_black_box, r=alexcrichton

    Moves test::black_box to core::hint and fix black_box on wasm32 and asm.js
    
    This changes removes a cyclic dependency between the "test" and "libtest"
    crates, where "libtest" depends on "test" for "black_box", but "test" depends on
    "libtest" for everything else.
    
    I've chosen the "hint" module because there seems to be enough consensus in the
    discussion of RFC2360 that this module is where such an intrinsic would belong,
    but this PR does not implement that RFC! If that RFC ever gets merged, the API, docs,
    etc. of this API will need to change. This PR just move the implementation of the
    already existing API.
    
    For backwards compatibility reasons I've chosen to also keep the "test" feature
    gate for these instead of adding a new feature gate. If we change the feature
    gate, we'll potentially all benchmarks, and while that's something that we could
    do, it seems unnecessary to do that now - if RFC2360 gets merged, we'll need to
    do that anyways. Backwards compatibility is also why we continue to re-export
    "black_box" from the "test" crate.
    
    This PR also fixes black_box on the wasm32 target, which now supports inline assembly, and uses volatile loads on the asm.js target.
    
    r? @Amanieu (cc @rust-lang/libs)
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    f9ae15f View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#59362 - pnkfelix:demo-from-iterator-short-c…

    …ircuiting, r=Centril
    
    Demo `FromIterator` short-circuiting
    
    while looking at a FIXME in `FromIterator for Option` and `FromIterator for Result`, I realized that the current documentation does not have example code showing exactly what is meant by "no further elements are taken."
    
    The code snippets provided here are meant to correct that.
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    ea51c8b View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe

    add rustfix-able suggestions to trim_{left,right} deprecations
    
    Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    cb15da7 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#59374 - faern:simplify-checked-duration-sin…

    …ce, r=shepmaster
    
    Simplify checked_duration_since
    
    This follows the same design as we updated to in rust-lang#56490. Internally, all the system specific time implementations are checked, no panics. Then the panicking publicly exported API can just call the checked version of itself and make do with a single panic (`expect`) at the top.
    
    Since the internal sys implementations are now checked, this gets rid of the extra `if self >= &earlier` check in `checked_duration_since`. Except likely making the generated machine code simpler, it also reduces the algorithm from "Check panic condition -> call possibly panicking method" to just "call non panicking method".
    
    Added two test cases:
    * Edge case: Make sure `checked_duration_since` on two equal `Instant`s produce a zero duration, not a `None`.
    * Most common/intended usage: Make sure `later.checked_duration_since(earlier)`, returns an expected value.
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    8aa161b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#59389 - euclio:deprecated-suggestion, r=varkor

    replace redundant note in deprecation warning
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    e5f4755 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#59410 - tbu-:pr_doc_clarifyclamp, r=joshtri…

    …plett
    
    Clarify `{Ord,f32,f64}::clamp` docs a little
    
    Explicitly call out when it returns NaN, adhere to the panic doc
    guidelines.
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    25f3ae9 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#59419 - frewsxcv:frewsxcv-qu, r=varkor

    Utilize `?` instead of `return None`.
    
    None
    Centril committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    5059a9a View commit details
    Browse the repository at this point in the history