Rollup of 8 pull requests #69827

Centril · 2020-03-08T14:50:47Z

Successful merges:

remove non-sysroot sources from rust-src component #69631 (remove non-sysroot sources from rust-src component)
Miri visitor: detect primitive types based on type, not layout (also, more tests) #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests))
Try to ensure usize marker does not get merged #69651 (Try to ensure usize marker does not get merged)
More documentation and simplification of BTreeMap's internals #69668 (More documentation and simplification of BTreeMap's internals)
unix: Don't override existing SIGSEGV/BUS handlers #69685 (unix: Don't override existing SIGSEGV/BUS handlers)
Cleanup E0390 explanation #69771 (Cleanup E0390 explanation)
Add missing ` in doc for File::with_options() #69777 (Add missing ` in doc for File::with_options())
Refactorings to method/probe.rs and CrateId #69812 (Refactorings to method/probe.rs and CrateId)

Failed merges:

Although `stack_overflow::init` runs very early in the process, even before `main`, there may already be signal handlers installed for things like the address sanitizer. In that case, just leave it alone, and don't bother trying to allocate our own signal stacks either.

…, really

@eddyb

remove non-sysroot sources from rust-src component See rust-lang#69592 (comment): these were likely added in rust-lang#58269 for the sake of compiler plugins, but those are being entirely phased out, so there is no good reason to ship these sources. OTOH, @eddyb [wrote](rust-lang#58269 (comment)) > Yeah, my question is why librustc_plugin specifically? Everything else makes sense. So maybe there is some good reason to keep these? Then we should have a comment explaining that reason. Cc @eddyb @taeguk @Mark-Simulacrum

@eddyb

Miri visitor: detect primitive types based on type, not layout (also, more tests) I also converted the union-based transmutes to use `mem::transmute` for increased readability. r? @eddyb @oli-obk

…=eddyb Try to ensure usize marker does not get merged This follows up on [this conversation](rust-lang#69209 (comment)). However, I'm not confident this is quite correct, so feedback is appreciated, as always.

…, r=Mark-Simulacrum More documentation and simplification of BTreeMap's internals Salvage the documentation and simplification from rust-lang#67980, without changing the type locked down by debuginfo. r? @rkruppe

unix: Don't override existing SIGSEGV/BUS handlers Although `stack_overflow::init` runs very early in the process, even before `main`, there may already be signal handlers installed for things like the address sanitizer. In that case, just leave it alone, and don't bother trying to allocate our own signal stacks either. Fixes rust-lang#69524.

@Dylan-DPC

…an-DPC Cleanup E0390 explanation r? @Dylan-DPC

Add missing ` in doc for File::with_options()

Refactorings to method/probe.rs and CrateId A couple of refactorings done while looking into performance improvements in method resolution.

Centril · 2020-03-08T14:51:08Z

@bors r+ p=1001 rollup=never

bors · 2020-03-08T14:51:10Z

📌 Commit eb125f3 has been approved by Centril

bors · 2020-03-08T14:51:10Z

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

bors · 2020-03-08T14:51:21Z

⌛ Testing commit eb125f3 with merge 45b4fdb...

@ghost

Rollup of 8 pull requests Successful merges: - #69631 (remove non-sysroot sources from rust-src component) - #69646 (Miri visitor: detect primitive types based on type, not layout (also, more tests)) - #69651 (Try to ensure usize marker does not get merged) - #69668 (More documentation and simplification of BTreeMap's internals) - #69685 (unix: Don't override existing SIGSEGV/BUS handlers) - #69771 (Cleanup E0390 explanation) - #69777 (Add missing ` in doc for File::with_options()) - #69812 (Refactorings to method/probe.rs and CrateId) Failed merges: r? @ghost

rust-highfive · 2020-03-08T15:50:32Z

The job dist-x86_64-apple of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-08T15:48:40.6206330Z   local time: Sun Mar  8 15:48:40 UTC 2020
2020-03-08T15:48:40.6744460Z   network time: Sun, 08 Mar 2020 15:48:40 GMT
2020-03-08T15:48:40.6846510Z == end clock drift check ==
2020-03-08T15:48:40.6903970Z 
2020-03-08T15:48:40.6948060Z ##[error]Bash exited with code '1'.
2020-03-08T15:48:40.7029620Z ##[section]Starting: Checkout rust-lang/rust@auto to s
2020-03-08T15:48:40.7036610Z ==============================================================================
2020-03-08T15:48:40.7037040Z Task         : Get sources
2020-03-08T15:48:40.7037460Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

bors · 2020-03-08T15:50:45Z

💔 Test failed - checks-azure

RalfJung and others added 26 commits March 2, 2020 10:13

remove non-sysroot sources from rust-src component

cbf52b1

Try to ensure usize marker does not get merged

a9259fb

Documentation and slight simplification of BTreeMap's internals

9384cba

Cleanup E0390 explanation

13d5ee1

Fix missing ` in doc for File::with_options

31183bb

'fieldless enums' is not what I meant -- it's empty/uninhabited enums…

6548be2

…, really

miri value visitor: detect primitives by type, not layout

d47196b

const validation ub tests: use transmute instead of unions

aa1435b

test that we validate boxes

4807e93

test some more kinds of enums with uninhabited variants

f481547

better error messages for invalid boxes (and a few more tests)

4584e75

please tidy

f0586f9

rename visit_primitive -> try_visit_primitive, and comments

58f8cc2

bug on ty::GeneratorWitness

295c2d6

refactor: Exhaustive matching in method/probe.rs

b1b558f

refactor: Move a borrow_mut and unwrap out of a loop

6095fa1

fix type size mismatch on 32bit

a95f00f

Rollup merge of rust-lang#69646 - RalfJung:layout-visitor, r=eddyb

8d25f2b

Miri visitor: detect primitive types based on type, not layout (also, more tests) I also converted the union-based transmutes to use `mem::transmute` for increased readability. r? @eddyb @oli-obk

Rollup merge of rust-lang#69651 - Mark-Simulacrum:black-box-marker, r…

850e515

…=eddyb Try to ensure usize marker does not get merged This follows up on [this conversation](rust-lang#69209 (comment)). However, I'm not confident this is quite correct, so feedback is appreciated, as always.

Rollup merge of rust-lang#69771 - GuillaumeGomez:cleanup-e0390, r=Dyl…

919ae59

…an-DPC Cleanup E0390 explanation r? @Dylan-DPC

Rollup merge of rust-lang#69777 - lukas-code:patch-1, r=jonas-schievink

9ea18a6

Add missing ` in doc for File::with_options()

Rollup merge of rust-lang#69812 - Marwes:refactor, r=petrochenkov

eb125f3

Refactorings to method/probe.rs and CrateId A couple of refactorings done while looking into performance improvements in method resolution.

Centril added the rollup A PR which is a rollup label Mar 8, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 8, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 8, 2020

Centril closed this Mar 8, 2020

Centril deleted the rollup-jlfos3x branch March 8, 2020 15:51

Centril mentioned this pull request Mar 8, 2020

unix: Don't override existing SIGSEGV/BUS handlers #69685

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 8 pull requests #69827

Rollup of 8 pull requests #69827

Centril commented Mar 8, 2020

Centril commented Mar 8, 2020

bors commented Mar 8, 2020

bors commented Mar 8, 2020

bors commented Mar 8, 2020

rust-highfive commented Mar 8, 2020

bors commented Mar 8, 2020

Rollup of 8 pull requests #69827

Rollup of 8 pull requests #69827

Conversation

Centril commented Mar 8, 2020

Centril commented Mar 8, 2020

bors commented Mar 8, 2020

bors commented Mar 8, 2020

bors commented Mar 8, 2020

rust-highfive commented Mar 8, 2020

bors commented Mar 8, 2020