resolve: Some module-related refactorings #88872
Conversation
|
Some changes occurred in intra-doc-links. cc @jyn514 |
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
petrochenkov
force-pushed
the
getmod2
branch
from
ec5dbc2
to
7e407f9
Compare
| self.cstore().module_expansion_untracked(def_id, &self.session), | ||
| self.cstore().get_span_untracked(def_id, &self.session), | ||
| )); | ||
| // FIXME: Account for `#[no_implicit_prelude]` attributes. | ||
| parent.map_or(false, |module| module.no_implicit_prelude), |
There was a problem hiding this comment.
The ModuleData::new used to set no_implicit_module to false. What are the consequences of this change in behaviour?
There was a problem hiding this comment.
For enums and traits there should be no consequences (we are jumping out of these modules during resolution and don't use their no_implicit_prelude flags), for foreign modules there may be some effect on macros 2.0 - identifiers from macros with def-site located in a foreign no_implicit_prelude module should now skip prelude during resolution.
However, because the #[no_implicit_prelude] attributes are still not applied to foreign modules the inherited value is always false, so no change in behavior right now.
petrochenkov
force-pushed
the
getmod2
branch
from
7e407f9
to
fd23c83
Compare
|
I've included #88917 into this PR as well. |
|
@bors r+ |
|
📌 Commit fd23c8348d27dbfe45916094306672a39c4c7e4a has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit fd23c8348d27dbfe45916094306672a39c4c7e4a with merge 76a61b10ee24d792ad456dcb526d716df8833711... |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bors
added
S-waiting-on-review
petrochenkov
force-pushed
the
getmod2
branch
from
fd23c83
to
6126744
Compare
|
📌 Commit 61267440bbba0c29ef89e7bf988f77ab4a5abf16 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 61267440bbba0c29ef89e7bf988f77ab4a5abf16 with merge 691dbccc3a019db5ce6b6d31f8216b37bef09e9e... |
This comment has been minimized.
This comment has been minimized.
bors
removed
the
S-waiting-on-bors
bors
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Construction of all modules is now centralized and performed by `fn new_module`.
The `Option<Module>` version is supported for the case where we don't know whether the `DefId` refers to a module or not. Non-local traits and enums are also correctly found now.
petrochenkov
force-pushed
the
getmod2
branch
from
6126744
to
8f035b8
Compare
|
@bors r=cjgillot |
|
📌 Commit 8f035b8 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (7342213): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
resolve: Cache module loading for all foreign modules It was previously cached for modules loaded from `fn get_module`, but not for modules loaded from `fn build_reduced_graph_for_external_crate_res`. This also makes all foreign modules use their real parent, span and expansion instead of possibly a parent/span/expansion of their reexport. Modules are also often compared using referential equality (`ptr::eq`), this change makes such comparisons correct in all cases. An ICE happening on attempt to decode expansions for foreign enums and traits is avoided. Also local enums and traits are now added to the module map. Follow up to rust-lang#88872. r? `@cjgillot`
See the individual commits.