Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perf experiment] resolve: Do not cache nearest parent mod in ModuleData #88917

Closed
wants to merge 1 commit into from

Conversation

petrochenkov
Copy link
Contributor

No description provided.

@rust-highfive
Copy link
Collaborator

r? @oli-obk

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 13, 2021
@petrochenkov
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Sep 13, 2021

⌛ Trying commit 8443ea9 with merge 73ea2bd112a8b357f9754dd10fb68933bb71f6b7...

@petrochenkov petrochenkov added S-waiting-on-perf Status: Waiting on a perf run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2021
@bors
Copy link
Contributor

bors commented Sep 13, 2021

☀️ Try build successful - checks-actions
Build commit: 73ea2bd112a8b357f9754dd10fb68933bb71f6b7 (73ea2bd112a8b357f9754dd10fb68933bb71f6b7)

@rust-timer
Copy link
Collaborator

Queued 73ea2bd112a8b357f9754dd10fb68933bb71f6b7 with parent 9bb77da, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (73ea2bd112a8b357f9754dd10fb68933bb71f6b7): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-perf Status: Waiting on a perf run to be completed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants