-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #98744
Rollup of 8 pull requests #98744
Commits on May 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 430575b - Browse repository at this point
Copy the full SHA 430575bView commit details
Commits on Jun 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5a70d88 - Browse repository at this point
Copy the full SHA 5a70d88View commit details
Commits on Jun 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6d6c63e - Browse repository at this point
Copy the full SHA 6d6c63eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2967127 - Browse repository at this point
Copy the full SHA 2967127View commit details -
Configuration menu - View commit details
-
Copy full SHA for b46f1c4 - Browse repository at this point
Copy the full SHA b46f1c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for b0c2030 - Browse repository at this point
Copy the full SHA b0c2030View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01c75e4 - Browse repository at this point
Copy the full SHA 01c75e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3dc7ae - Browse repository at this point
Copy the full SHA f3dc7aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for ded2bb5 - Browse repository at this point
Copy the full SHA ded2bb5View commit details
Commits on Jun 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9306e9a - Browse repository at this point
Copy the full SHA 9306e9aView commit details
Commits on Jun 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7cb4cef - Browse repository at this point
Copy the full SHA 7cb4cefView commit details -
Configuration menu - View commit details
-
Copy full SHA for 922ff84 - Browse repository at this point
Copy the full SHA 922ff84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d88993 - Browse repository at this point
Copy the full SHA 4d88993View commit details -
Configuration menu - View commit details
-
Copy full SHA for f8f9d01 - Browse repository at this point
Copy the full SHA f8f9d01View commit details -
Configuration menu - View commit details
-
Copy full SHA for f095f80 - Browse repository at this point
Copy the full SHA f095f80View commit details
Commits on Jun 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a5b6d25 - Browse repository at this point
Copy the full SHA a5b6d25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72c73f8 - Browse repository at this point
Copy the full SHA 72c73f8View commit details -
Rollup merge of rust-lang#97798 - WaffleLapkin:allow_for_suggestions_…
…that_are_quite_far_away_from_each_other, r=estebank Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown This is an attempt to fix suggestions one part of which is 6 lines or more far from the first. I've noticed "the problem" (of not showing some parts of the suggestion) here: rust-lang#97759 (comment). I'm not sure about the implementation (this big closure is just bad and makes already complicated code even more so), but I want to at least discuss the result. Here is an example of how this changes the output: Before: ```text help: consider enclosing expression in a block | 3 ~ 'l: { match () { () => break 'l, 4 | 5 | 6 | 7 | 8 | ... ``` After: ```text help: consider enclosing expression in a block | 3 ~ 'l: { match () { () => break 'l, 4 | ... 31| 32~ } }; | ``` r? `@estebank` `@rustbot` label +A-diagnostics +A-suggestion-diagnostics
Configuration menu - View commit details
-
Copy full SHA for 51e2d6a - Browse repository at this point
Copy the full SHA 51e2d6aView commit details -
Rollup merge of rust-lang#98191 - TaKO8Ki:remove-rest-of-unnecessary-…
…to-string, r=Dylan-DPC Remove the rest of unnecessary `to_string` I removed most of unnecessary `to_string` in rust-lang#98043. This patch removes the rest of them I missed.
Configuration menu - View commit details
-
Copy full SHA for 2cc798b - Browse repository at this point
Copy the full SHA 2cc798bView commit details -
feat(lint): add default_iter_empty
Update description in clippy_lints/src/default_iter_empty.rs Co-authored-by: Fridtjof Stoldt <xFrednet@gmail.com> Update clippy_lints/src/default_iter_empty.rs Co-authored-by: Alex Macleod <alex@macleod.io> Update clippy_lints/src/default_iter_empty.rs Co-authored-by: Alex Macleod <alex@macleod.io> renamed default_iter_empty to default_instead_of_iter_empty Avoid duplicate messages add tests for regression rewrite 'Why is this bad?' cargo dev fmt delete default_iter_empty lint in renamed_lint.rs rewrite a message in the suggestion cargo dev update_lints --check
Configuration menu - View commit details
-
Copy full SHA for 2bb8c45 - Browse repository at this point
Copy the full SHA 2bb8c45View commit details -
Configuration menu - View commit details
-
Copy full SHA for 697c75e - Browse repository at this point
Copy the full SHA 697c75eView commit details -
Auto merge of rust-lang#97892 - klensy:fix-spaces, r=oli-obk
diagnostics: remove trailing spaces Remove few occurrences of trailing spaces and drive by fix of needless alloc of const string.
Configuration menu - View commit details
-
Copy full SHA for 09c9301 - Browse repository at this point
Copy the full SHA 09c9301View commit details -
Auto merge of rust-lang#8989 - kyoto7250:default_iter_empty, r=Alexendoo
feat(lint): add default_iter_empty close rust-lang#8915 This PR adds `default_iter_empty` lint. This lint checks `std::iter::Empty::default()` and replace with `std::iter::empty()`. Thank you in advance. --- changelog: add `default_instead_of_iter_empty` lint.
Configuration menu - View commit details
-
Copy full SHA for e933bb6 - Browse repository at this point
Copy the full SHA e933bb6View commit details
Commits on Jun 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f411c18 - Browse repository at this point
Copy the full SHA f411c18View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a83809 - Browse repository at this point
Copy the full SHA 7a83809View commit details -
Configuration menu - View commit details
-
Copy full SHA for 040d45e - Browse repository at this point
Copy the full SHA 040d45eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a02ae9 - Browse repository at this point
Copy the full SHA 4a02ae9View commit details -
Configuration menu - View commit details
-
Copy full SHA for a9215d9 - Browse repository at this point
Copy the full SHA a9215d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeedf72 - Browse repository at this point
Copy the full SHA eeedf72View commit details -
Rollup merge of rust-lang#98165 - WaffleLapkin:once_things_renamings,…
… r=m-ou-se once cell renamings This PR does the renamings proposed in rust-lang#74465 (comment) - Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}` - Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}` (I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc) ```@rustbot``` label +T-libs-api -T-libs
Configuration menu - View commit details
-
Copy full SHA for 4737e9e - Browse repository at this point
Copy the full SHA 4737e9eView commit details
Commits on Jun 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e7ed42 - Browse repository at this point
Copy the full SHA 4e7ed42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9395c26 - Browse repository at this point
Copy the full SHA 9395c26View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee37029 - Browse repository at this point
Copy the full SHA ee37029View commit details
Commits on Jun 20, 2022
-
Auto merge of rust-lang#9016 - Alexendoo:needless-return-test, r=gira…
…ffate Use `RefCell` in `needless_return` tests changelog: none The stdio locks no longer fail to compile if the `return` is removed due to them now being `'static` (rust-lang#9008)
Configuration menu - View commit details
-
Copy full SHA for 9d92af7 - Browse repository at this point
Copy the full SHA 9d92af7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 46d056e - Browse repository at this point
Copy the full SHA 46d056eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 39ffda0 - Browse repository at this point
Copy the full SHA 39ffda0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a4b5cf - Browse repository at this point
Copy the full SHA 4a4b5cfView commit details -
Auto merge of rust-lang#9023 - unvalley:add-meta-tag-for-lint-list, r…
…=xFrednet Add description meta tag for lint list closes rust-lang#8975 changelog:none
Configuration menu - View commit details
-
Copy full SHA for 195f2cb - Browse repository at this point
Copy the full SHA 195f2cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0b107b - Browse repository at this point
Copy the full SHA a0b107bView commit details -
Auto merge of rust-lang#9025 - Alexendoo:unused-async-method, r=dswij
unused_async: lint async methods Now lints: ```rust impl Foo { async fn method(&self) -> &'static str { "no await here" } } ``` changelog: [`unused_async`]: lint async methods Fixes rust-lang#9024
Configuration menu - View commit details
-
Copy full SHA for 97d4513 - Browse repository at this point
Copy the full SHA 97d4513View commit details -
Auto merge of rust-lang#9006 - kyoto7250:issue-8836-v2, r=Jarcho
feat(fix): ignore `todo!` and `unimplemented!` in `if_same_then_else` close: rust-lang#8836 take over: rust-lang#8853 This PR adds check `todo!` and `unimplemented!` in if_same_then_else. ( I thought `unimplemented` should not be checked as well as todo!.) Thank you in advance. changelog: ignore todo! and unimplemented! in if_same_then_else r? `@Jarcho`
Configuration menu - View commit details
-
Copy full SHA for 93c6f9e - Browse repository at this point
Copy the full SHA 93c6f9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fc84d4 - Browse repository at this point
Copy the full SHA 6fc84d4View commit details
Commits on Jun 21, 2022
-
Add details about significant drop in match scrutinees causing deadlocks
Adds more details about how a significant drop in a match scrutinee can cause a deadlock and include link to documentation. Emits messages indicating temporaries with significant drops in arms of matches and message about possible deadlocks/unexpected behavior. changelog: Add more details to significant drop lint to explicitly show how temporaries in match scrutinees can cause deadlocks/unexpected behavior.
Configuration menu - View commit details
-
Copy full SHA for 2476100 - Browse repository at this point
Copy the full SHA 2476100View commit details -
For
example should be used insteadwhile
in WHILE_LET_ON_ITERATOR`For` example should be used instead `while` in WHILE_LET_ON_ITERATOR For example should be used instead while in WHILE_LET_ON_ITERATOR Revert some changes Fix cargo dev fmt
Configuration menu - View commit details
-
Copy full SHA for dc7f227 - Browse repository at this point
Copy the full SHA dc7f227View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bd1581 - Browse repository at this point
Copy the full SHA 2bd1581View commit details -
Configuration menu - View commit details
-
Copy full SHA for 890fd0e - Browse repository at this point
Copy the full SHA 890fd0eView commit details -
Implement manual_rem_euclid lint
Evan Typanski committedJun 21, 2022 Configuration menu - View commit details
-
Copy full SHA for e5ebd3e - Browse repository at this point
Copy the full SHA e5ebd3eView commit details -
Fix case where suggestion errored for infer type
Evan Typanski committedJun 21, 2022 Configuration menu - View commit details
-
Copy full SHA for 6e1df47 - Browse repository at this point
Copy the full SHA 6e1df47View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab645bb - Browse repository at this point
Copy the full SHA ab645bbView commit details
Commits on Jun 22, 2022
-
Auto merge of rust-lang#9017 - alex-semenyuk:while_let_on_iterator_do…
…c_fix, r=giraffate Example for `WHILE_LET_ON_ITERATOR` changelog: none example for `WHILE_LET_ON_ITERATOR`, using `for` instead of `while let`
Configuration menu - View commit details
-
Copy full SHA for bc0bf06 - Browse repository at this point
Copy the full SHA bc0bf06View commit details -
Auto merge of rust-lang#9030 - Serial-ATA:remove-clippy-dev-dep, r=fl…
…ip1995 Remove `cargo_dev` dependency changelog: none Sorry about that 😅. r? `@flip1995`
Configuration menu - View commit details
-
Copy full SHA for f9fea17 - Browse repository at this point
Copy the full SHA f9fea17View commit details -
Configuration menu - View commit details
-
Copy full SHA for b969326 - Browse repository at this point
Copy the full SHA b969326View commit details -
Evan Typanski committed
Jun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 75ed0c9 - Browse repository at this point
Copy the full SHA 75ed0c9View commit details -
Fix case where rem was considered commutative
Evan Typanski committedJun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 93e41d3 - Browse repository at this point
Copy the full SHA 93e41d3View commit details -
Prefer if let chain over macro
Evan Typanski committedJun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for c8df6d6 - Browse repository at this point
Copy the full SHA c8df6d6View commit details -
Evan Typanski committed
Jun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 90f8277 - Browse repository at this point
Copy the full SHA 90f8277View commit details -
Add MSRV check for const rem_euclid
Evan Typanski committedJun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 61e1870 - Browse repository at this point
Copy the full SHA 61e1870View commit details -
Evan Typanski committed
Jun 22, 2022 Configuration menu - View commit details
-
Copy full SHA for 0447cc7 - Browse repository at this point
Copy the full SHA 0447cc7View commit details -
Auto merge of rust-lang#9026 - hellow554:neg_multiply_precedence, r=x…
…Frednet put parentheses around neg_multiply suggestion if needed *Please write a short comment explaining your change (or "none" for internal only changes)* changelog: [`neg_multiply`]: put parentheses around suggestion if needed
Configuration menu - View commit details
-
Copy full SHA for 3d366fc - Browse repository at this point
Copy the full SHA 3d366fcView commit details -
Auto merge of rust-lang#9028 - kyoto7250:issue_8798, r=xFrednet
confirm using chain in collapsible_span_lint_calls close rust-lang#8798 This PR fixes false positive when using chain in `collapsible_span_lint_calls`. changelog: None
Configuration menu - View commit details
-
Copy full SHA for 6985e65 - Browse repository at this point
Copy the full SHA 6985e65View commit details -
Auto merge of rust-lang#9034 - alex-semenyuk:example_vec_resize_to_ze…
…ro, r=giraffate Example for VEC_RESIZE_TO_ZERO changelog: none Example for VEC_RESIZE_TO_ZERO - what we should use instead
Configuration menu - View commit details
-
Copy full SHA for 2cc5211 - Browse repository at this point
Copy the full SHA 2cc5211View commit details
Commits on Jun 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 87eded6 - Browse repository at this point
Copy the full SHA 87eded6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1f707db - Browse repository at this point
Copy the full SHA 1f707dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4182803 - Browse repository at this point
Copy the full SHA 4182803View commit details -
Split constant check functions and simplify
Evan Typanski committedJun 23, 2022 Configuration menu - View commit details
-
Copy full SHA for 92704b4 - Browse repository at this point
Copy the full SHA 92704b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebf77f6 - Browse repository at this point
Copy the full SHA ebf77f6View commit details -
Add external macro guard and test middle MSRV
Evan Typanski committedJun 23, 2022 Configuration menu - View commit details
-
Copy full SHA for df26c3f - Browse repository at this point
Copy the full SHA df26c3fView commit details -
Auto merge of rust-lang#8953 - DevAccentor:slow_vector_initialization…
…, r=Manishearth add vec.capacity() to [`slow_vec_initialization`] detection fix rust-lang#8800 for example ```rust let mut vec1 = Vec::with_capacity(len); vec1.resize(vec1.capacity(), 0); let mut vec2 = Vec::with_capacity(len); vec2.extend(repeat(0).take(vec2.capacity())); ``` will trigger the lint --- changelog: add `vec.capacity()` to [`slow_vec_initialization`] detection
Configuration menu - View commit details
-
Copy full SHA for f718984 - Browse repository at this point
Copy the full SHA f718984View commit details
Commits on Jun 24, 2022
-
Auto merge of rust-lang#9036 - xFrednet:0000-force-warn-in-driver, r=…
…dswij Check for `--force-warn` in Clippy's driver run condition Just a thing I've noticed while tinkering on the driver. Currently, the driver only checks for `--cap-lints=allow` to determine if Clippy should run on the code, but ignores possible `--force-warn` arguments --- changelog: Others: Allowing all lints and only `--force-warn`ing some will now work with Clippy's driver
Configuration menu - View commit details
-
Copy full SHA for 3f47cd1 - Browse repository at this point
Copy the full SHA 3f47cd1View commit details -
Auto merge of rust-lang#9037 - smoelius:fix-extra-unused-lifetimes-fp…
…, r=dswij Fix `extra_unused_lifetimes` false positive This PR fixes rust-lang#9014. I confirmed the FP on the `crates.io` source as `@JohnTitor` mentioned, and confirmed that the FP is no longer present following this change. I did not include a test in this PR because I think constructing one would be complicated, and the fix is pretty simple. But please let me know if this is unacceptable. changelog: fix `extra_unused_lifetimes` FP
Configuration menu - View commit details
-
Copy full SHA for 1d1ae10 - Browse repository at this point
Copy the full SHA 1d1ae10View commit details -
Add test for
extra_unused_lifetimes
FP on deriveThis commit adds test for a `extra_unused_lifetimes` false positive from derive (rust-lang#9014). The fix for the FP is introduced in rust-lang#9037.
Configuration menu - View commit details
-
Copy full SHA for a8f6824 - Browse repository at this point
Copy the full SHA a8f6824View commit details -
Auto merge of rust-lang#9031 - evantypanski:manual_rem_euclid, r=Jarcho
Add [`manual_rem_euclid`] lint Closes rust-lang#8883 Adds a lint for checking manual use of `rem_euclid(n)` changelog: Add [`manual_rem_euclid`] lint
Configuration menu - View commit details
-
Copy full SHA for e17864e - Browse repository at this point
Copy the full SHA e17864eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aec465c - Browse repository at this point
Copy the full SHA aec465cView commit details
Commits on Jun 25, 2022
-
Auto merge of rust-lang#9015 - kyoto7250:issue_8493, r=Jarcho
ignore item in `thread_local!` macro close rust-lang#8493 This PR ignores `thread_local` macro in `declare_interior_mutable_const`. changelog: ignore `thread_local!` macro in `declare_interior_mutable_const`
Configuration menu - View commit details
-
Copy full SHA for 93ebd0e - Browse repository at this point
Copy the full SHA 93ebd0eView commit details -
Suggest
pointer::cast
when possible intransmute_ptr_to_ref
Defensively add a cast to any type with lifetimes.
Configuration menu - View commit details
-
Copy full SHA for 7cdaabc - Browse repository at this point
Copy the full SHA 7cdaabcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7c55a4 - Browse repository at this point
Copy the full SHA e7c55a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 811d73a - Browse repository at this point
Copy the full SHA 811d73aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3c7101 - Browse repository at this point
Copy the full SHA a3c7101View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6ee6bb - Browse repository at this point
Copy the full SHA b6ee6bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for b297698 - Browse repository at this point
Copy the full SHA b297698View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54ad99b - Browse repository at this point
Copy the full SHA 54ad99bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bdc6ece - Browse repository at this point
Copy the full SHA bdc6eceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 79fc271 - Browse repository at this point
Copy the full SHA 79fc271View commit details -
Configuration menu - View commit details
-
Copy full SHA for ae4900c - Browse repository at this point
Copy the full SHA ae4900cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 525f5ee - Browse repository at this point
Copy the full SHA 525f5eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6427ba4 - Browse repository at this point
Copy the full SHA 6427ba4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d41a97 - Browse repository at this point
Copy the full SHA 4d41a97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a31ef7 - Browse repository at this point
Copy the full SHA 3a31ef7View commit details -
Auto merge of rust-lang#8985 - botahamec:single-match-option, r=llogiq
Lint `[single_match]` on `Option` matches fixes rust-lang#8928 changelog: did some cleanup of the logic for ``[`single_match`]`` and ``[`single_match_else`]`` which fixes the bug where `Option` matches were not linted unless a wildcard was used for one of the arms.
Configuration menu - View commit details
-
Copy full SHA for 8789f4e - Browse repository at this point
Copy the full SHA 8789f4eView commit details
Commits on Jun 26, 2022
-
Co-authored-by: llogiq <bogusandre@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for bf317a8 - Browse repository at this point
Copy the full SHA bf317a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d827b83 - Browse repository at this point
Copy the full SHA d827b83View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4065702 - Browse repository at this point
Copy the full SHA 4065702View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1691914 - Browse repository at this point
Copy the full SHA 1691914View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11bf291 - Browse repository at this point
Copy the full SHA 11bf291View commit details -
Auto merge of rust-lang#9055 - kyoto7250:update_nodejs_in_github_acti…
…on, r=Manishearth update node.js version in `remark.yml` Optional chain (`?.`) is available in `node v14`, but node version in CI is `node v12`, so CI is failed now. ref: https://github.com/rust-lang/rust-clippy/runs/7059529735?check_suite_focus=true optional chain: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#browser_compatibility Corresponding PR (maybe) remarkjs/remark#1007 changelog: None
Configuration menu - View commit details
-
Copy full SHA for ab58276 - Browse repository at this point
Copy the full SHA ab58276View commit details -
Auto merge of rust-lang#9032 - kyoto7250:issue_9018, r=llogiq
enum_variant_names should ignore when all prefixes are _ close rust-lang#9018 When Enum prefix is only an underscore, we should not issue warnings. changelog: fix false positive in enum_variant_names
Configuration menu - View commit details
-
Copy full SHA for 9b15062 - Browse repository at this point
Copy the full SHA 9b15062View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f2b8e6 - Browse repository at this point
Copy the full SHA 5f2b8e6View commit details -
Update clippy_lints/src/use_retain.rs
Co-authored-by: llogiq <bogusandre@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b20b8f1 - Browse repository at this point
Copy the full SHA b20b8f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3afc72 - Browse repository at this point
Copy the full SHA e3afc72View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3953c53 - Browse repository at this point
Copy the full SHA 3953c53View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd629c0 - Browse repository at this point
Copy the full SHA fd629c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1421211 - Browse repository at this point
Copy the full SHA 1421211View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4decfde - Browse repository at this point
Copy the full SHA 4decfdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd3d0fd - Browse repository at this point
Copy the full SHA dd3d0fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a9c0ef - Browse repository at this point
Copy the full SHA 3a9c0efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 676af45 - Browse repository at this point
Copy the full SHA 676af45View commit details
Commits on Jun 27, 2022
-
Auto merge of rust-lang#8939 - Jarcho:transmute_ptr_to_ref_lt, r=gira…
…ffate Suggest `pointer::cast` when possible in `transmute_ptr_to_ref` fixes rust-lang#8924 changelog: Suggest casting the pointer for any type containing lifetimes in `transmute_ptr_to_ref`. changelog: Suggest `pointer::cast` when possible in `transmute_ptr_to_ref`.
Configuration menu - View commit details
-
Copy full SHA for 88da5f2 - Browse repository at this point
Copy the full SHA 88da5f2View commit details -
Auto merge of rust-lang#8871 - Serial-ATA:cargo-dev-deprecate, r=gira…
…ffate Add `cargo dev deprecate` changelog: none I wrote this awhile ago when `regex` was still a dependency. Is it alright to add it back?
Configuration menu - View commit details
-
Copy full SHA for 57e7e1d - Browse repository at this point
Copy the full SHA 57e7e1dView commit details -
Auto merge of rust-lang#9054 - alex-semenyuk:string_add_example, r=gi…
…raffate STRING_ADD example changelog: none STRING_ADD example, how it should be
Configuration menu - View commit details
-
Copy full SHA for 6b762ee - Browse repository at this point
Copy the full SHA 6b762eeView commit details -
Fix
let_undescore_lock
false-positive when binding without lockingSigned-off-by: Klim Tsoutsman <klimusha@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 65f700f - Browse repository at this point
Copy the full SHA 65f700fView commit details -
Auto merge of rust-lang#8990 - tsoutsman:master, r=llogiq
Fix `let_undescore_lock` false-positive when binding without locking Fixes rust-lang#8486. changelog: Fix `let_undescore_lock` false-positive when binding without locking.
Configuration menu - View commit details
-
Copy full SHA for 889b361 - Browse repository at this point
Copy the full SHA 889b361View commit details -
Auto merge of rust-lang#8972 - kyoto7250:use_retain, r=llogiq
feat(new lint): new lint `manual_retain` close rust-lang#8097 This PR is a new lint implementation. This lint checks if the `retain` method is available. Thank you in advance. changelog: add new ``[`manual_retain`]`` lint
Configuration menu - View commit details
-
Copy full SHA for eaa03ea - Browse repository at this point
Copy the full SHA eaa03eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6a2221 - Browse repository at this point
Copy the full SHA c6a2221View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2315f76 - Browse repository at this point
Copy the full SHA 2315f76View commit details -
Configuration menu - View commit details
-
Copy full SHA for c10101c - Browse repository at this point
Copy the full SHA c10101cView commit details -
Auto merge of rust-lang#8649 - ebobrow:imperative_find, r=flip1995
add [`manual_find`] lint for function return case part of the implementation discussed in rust-lang#7143 changelog: add [`manual_find`] lint for function return case
Configuration menu - View commit details
-
Copy full SHA for fdd0e72 - Browse repository at this point
Copy the full SHA fdd0e72View commit details -
Auto merge of rust-lang#9045 - alex-semenyuk:self_assignment_example,…
… r=llogiq Fix example `SELF_ASSIGNMENT` changelog: Fix example in `SELF_ASSIGNMENT` docs
Configuration menu - View commit details
-
Copy full SHA for d855395 - Browse repository at this point
Copy the full SHA d855395View commit details
Commits on Jun 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3cfd1e5 - Browse repository at this point
Copy the full SHA 3cfd1e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bc4096 - Browse repository at this point
Copy the full SHA 7bc4096View commit details -
try reading rust-version from Cargo.toml
Cargo.toml can contain a field `rust-version`, that acts like a MSRV of clippy.toml file: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field This will try to read that field and use it, if the clippy.toml config has no `msrv` entry
Configuration menu - View commit details
-
Copy full SHA for 81737bf - Browse repository at this point
Copy the full SHA 81737bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 83511d1 - Browse repository at this point
Copy the full SHA 83511d1View commit details -
parse
Cargo.toml
file in ui-cargo testscompiletest_rs is not meant to test full cargo projects, but instead only files. So we need to parse the `Cargo.toml` file ourself and set the corresponding environment variable. In this case we just set `CARGO_PKG_RUST_VERSION`, nothing more. But, of course, this can be extended.
Configuration menu - View commit details
-
Copy full SHA for 6384765 - Browse repository at this point
Copy the full SHA 6384765View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0a1cd5 - Browse repository at this point
Copy the full SHA f0a1cd5View commit details -
Auto merge of rust-lang#8639 - Jarcho:trivially_copy_pass_by_ref_5953…
…, r=dswij `trivially_copy_pass_by_ref` fixes fixes rust-lang#5953 fixes rust-lang#2961 The fix for rust-lang#5953 is overly aggressive, but the suggestion is so bad that it's worth the false negatives. Basically three things together: * It's not obviously wrong * It compiles * It may actually work when tested changelog: Don't lint `trivially_copy_pass_by_ref` when unsafe pointers are used. changelog: Better track lifetimes when linting `trivially_copy_pass_by_ref`.
Configuration menu - View commit details
-
Copy full SHA for 373bb57 - Browse repository at this point
Copy the full SHA 373bb57View commit details -
Auto merge of rust-lang#8774 - hellow554:cargo-rust-version, r=flip1995
try reading rust-version from Cargo.toml Cargo.toml can contain a field `rust-version`, that acts like a MSRV of clippy.toml file: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field This will try to read that field and use it, if the clippy.toml config has no `msrv` entry changelog: respect `rust-version` from `Cargo.toml` closes rust-lang#8746 closes rust-lang#7765
Configuration menu - View commit details
-
Copy full SHA for b776fb8 - Browse repository at this point
Copy the full SHA b776fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d11618e - Browse repository at this point
Copy the full SHA d11618eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c107c97 - Browse repository at this point
Copy the full SHA c107c97View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a74d33 - Browse repository at this point
Copy the full SHA 8a74d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee532c0 - Browse repository at this point
Copy the full SHA ee532c0View commit details -
Merge different parent walking loops in
dereference.rs
`needless_borrow` will now walk further to find the target type.
Configuration menu - View commit details
-
Copy full SHA for a187d64 - Browse repository at this point
Copy the full SHA a187d64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20ea262 - Browse repository at this point
Copy the full SHA 20ea262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 442a68c - Browse repository at this point
Copy the full SHA 442a68cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 65bc6cb - Browse repository at this point
Copy the full SHA 65bc6cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0204b95 - Browse repository at this point
Copy the full SHA 0204b95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0b4ba73 - Browse repository at this point
Copy the full SHA 0b4ba73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d21b79 - Browse repository at this point
Copy the full SHA 6d21b79View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9788107 - Browse repository at this point
Copy the full SHA 9788107View commit details -
Configuration menu - View commit details
-
Copy full SHA for 15df228 - Browse repository at this point
Copy the full SHA 15df228View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85c1f74 - Browse repository at this point
Copy the full SHA 85c1f74View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd78ce7 - Browse repository at this point
Copy the full SHA dd78ce7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 448b6f4 - Browse repository at this point
Copy the full SHA 448b6f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 751131b - Browse repository at this point
Copy the full SHA 751131bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68a7fd2 - Browse repository at this point
Copy the full SHA 68a7fd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ac3626 - Browse repository at this point
Copy the full SHA 4ac3626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 732d716 - Browse repository at this point
Copy the full SHA 732d716View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0adb3c0 - Browse repository at this point
Copy the full SHA 0adb3c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3de70a4 - Browse repository at this point
Copy the full SHA 3de70a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 56f50d3 - Browse repository at this point
Copy the full SHA 56f50d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83de67c - Browse repository at this point
Copy the full SHA 83de67cView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8df16a - Browse repository at this point
Copy the full SHA a8df16aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0b0ee5 - Browse repository at this point
Copy the full SHA c0b0ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 71c2daa - Browse repository at this point
Copy the full SHA 71c2daaView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc5eac5 - Browse repository at this point
Copy the full SHA fc5eac5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92891a0 - Browse repository at this point
Copy the full SHA 92891a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5e2a2d3 - Browse repository at this point
Copy the full SHA 5e2a2d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for ffbba85 - Browse repository at this point
Copy the full SHA ffbba85View commit details -
Auto merge of rust-lang#8921 - Jarcho:merge_passes, r=llogiq
Add `Operators` lint pass changelog: None
Configuration menu - View commit details
-
Copy full SHA for 23c6765 - Browse repository at this point
Copy the full SHA 23c6765View commit details -
Auto merge of rust-lang#8355 - Jarcho:explicit_auto_deref_2, r=flip1995
Add lint `explicit_auto_deref` take 2 fixes: rust-lang#234 fixes: rust-lang#8367 fixes: rust-lang#8380 Still things to do: * ~~This currently only lints `&*<expr>` when it doesn't trigger `needless_borrow`.~~ * ~~This requires a borrow after a deref to trigger. So `*<expr>` changing `&&T` to `&T` won't be caught.~~ * The `deref` and `deref_mut` trait methods aren't linted. * Neither ~~field accesses~~, nor method receivers are linted. * ~~This probably shouldn't lint reborrowing.~~ * Full slicing to deref should probably be handled here as well. e.g. `&vec[..]` when just `&vec` would do changelog: new lint `explicit_auto_deref`
Configuration menu - View commit details
-
Copy full SHA for a4130e1 - Browse repository at this point
Copy the full SHA a4130e1View commit details -
Auto merge of rust-lang#9046 - xFrednet:rust-97660-expection-somethin…
…g-something, r=Jarcho Fix `#[expect]` for most clippy lints This PR fixes most `#[expect]` - lint interactions listed in rust-lang#97660. [My comment in the issue](rust-lang#97660 (comment)) shows the current progress (Once this is merged). I plan to work on `duplicate_mod` and `multiple_inherent_impl` and leave the rest for later. I feel like stabilizing the feature is more important than fixing the last few nits, which currently also don't work with `#[allow]`. --- changelog: none r? `@Jarcho` cc: rust-lang#97660
Configuration menu - View commit details
-
Copy full SHA for 4995b4e - Browse repository at this point
Copy the full SHA 4995b4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c6f362a - Browse repository at this point
Copy the full SHA c6f362aView commit details
Commits on Jun 29, 2022
-
Auto merge of rust-lang#8981 - PrestonFrom:more_details_for_significa…
…nt_drop_lint, r=flip1995 Add details about how significant drop in match scrutinees can cause deadlocks Adds more details about how a significant drop in a match scrutinee can cause a deadlock and include link to documentation. changelog: Add more details to significant drop lint to explicitly show how temporaries in match scrutinees can cause deadlocks.
Configuration menu - View commit details
-
Copy full SHA for 90227c1 - Browse repository at this point
Copy the full SHA 90227c1View commit details -
Auto merge of rust-lang#9043 - dswij:9037-test, r=Manishearth
`extra_unused_lifetimes` add FP test case emitting from derived attributes. Add test to cover for rust-lang#9014 which is fixed in rust-lang#9037. changelog: [`extra_unused_lifetimes`] Add FP test case emitting from derived attributes. --- Seeing the FP from the test: ```sh $ git revert -m 1 1d1ae10 $ TESTNAME=extra_unused_lifetime cargo uitest ```
Configuration menu - View commit details
-
Copy full SHA for 70f1d0d - Browse repository at this point
Copy the full SHA 70f1d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58434ae - Browse repository at this point
Copy the full SHA 58434aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for adbc849 - Browse repository at this point
Copy the full SHA adbc849View commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb6313 - Browse repository at this point
Copy the full SHA ddb6313View commit details
Commits on Jun 30, 2022
-
Clarify that flow sensitive checks now understand that *visibly* uninhabited call expressions never return. The change influences checks of reachable and unreachable code alike, not just dead code like previous wording would imply.
Configuration menu - View commit details
-
Copy full SHA for debee1e - Browse repository at this point
Copy the full SHA debee1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d75a9b - Browse repository at this point
Copy the full SHA 5d75a9bView commit details -
Auto merge of rust-lang#8666 - Jarcho:while_let_loop_7913, r=dswij
Don't lint `while_let_loop` when significant drop order would change fixes rust-lang#7226 fixes rust-lang#7913 fixes rust-lang#5717 For rust-lang#5717 it may not stay fully fixed. This is only completely fixed right now due to all the allowed drop impls have `#[may_dangle]` on their drop impls. This may get changed in the future based on how significant drops are determined, but the example listed with `RefCell` shouldn't break. changelog: Don't lint `while_let_loop` when the order of significant drops would change
Configuration menu - View commit details
-
Copy full SHA for 88591ba - Browse repository at this point
Copy the full SHA 88591baView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5d9e1b6 - Browse repository at this point
Copy the full SHA 5d9e1b6View commit details -
Auto merge of rust-lang#9068 - tamaroning:fix-typo-2022-6-30, r=giraf…
…fate,xFrednet fix typo in Clippy Lints page https://rust-lang.github.io/rust-clippy/master/#significant_drop_in_scrutinee changelog: none
Configuration menu - View commit details
-
Copy full SHA for ff3964a - Browse repository at this point
Copy the full SHA ff3964aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f26cf11 - Browse repository at this point
Copy the full SHA f26cf11View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf9b39a - Browse repository at this point
Copy the full SHA bf9b39aView commit details -
Configuration menu - View commit details
-
Copy full SHA for d9b2e21 - Browse repository at this point
Copy the full SHA d9b2e21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9de1f9f - Browse repository at this point
Copy the full SHA 9de1f9fView commit details -
Auto merge of rust-lang#9069 - flip1995:rustup, r=flip1995
Rustup r? `@ghost` changelog: none
Configuration menu - View commit details
-
Copy full SHA for 0cb0f76 - Browse repository at this point
Copy the full SHA 0cb0f76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 721d53a - Browse repository at this point
Copy the full SHA 721d53aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fead7a - Browse repository at this point
Copy the full SHA 5fead7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 29e0e14 - Browse repository at this point
Copy the full SHA 29e0e14View commit details -
Configuration menu - View commit details
-
Copy full SHA for c29e584 - Browse repository at this point
Copy the full SHA c29e584View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd7bd8b - Browse repository at this point
Copy the full SHA cd7bd8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fcf84a - Browse repository at this point
Copy the full SHA 3fcf84aView commit details -
Request to be notified of MIR changes
Adding myself (celinval) to be notified of PRs that changes the MIR.
Configuration menu - View commit details
-
Copy full SHA for d791310 - Browse repository at this point
Copy the full SHA d791310View commit details -
Rollup merge of rust-lang#98640 - cuviper:stable-rust-analyzer, r=Mar…
…k-Simulacrum Let rust-analyzer ship on stable, non-preview The consensus on rust-lang/rust-analyzer#12432 seems to be that we are ready for `rust-analyzer` to ship as a rustup component on the beta and stable channels. This won't always be the preferred distribution method, e.g. the VS Code extension will probably still independently update to its weekly releases, but it's still useful to have a component that follows the release train with the rest of the Rust toolchain. So this removes the nightly-only gating on the bundled component, and removes the "-preview" suffix as well by the usual renaming mechanism. cc `@rust-lang/wg-rls-2` `@rust-lang/release`
Configuration menu - View commit details
-
Copy full SHA for 399846d - Browse repository at this point
Copy the full SHA 399846dView commit details -
Rollup merge of rust-lang#98686 - matthiaskrgr:test-46511, r=compiler…
…-errors add ice test for 46511 Fixes rust-lang#46511 r? `@compiler-errors`
Configuration menu - View commit details
-
Copy full SHA for 7446818 - Browse repository at this point
Copy the full SHA 7446818View commit details -
Rollup merge of rust-lang#98706 - flip1995:clippyup, r=Dylan-DPC
Update Clippy r? `@Manishearth`
Configuration menu - View commit details
-
Copy full SHA for 0ab7073 - Browse repository at this point
Copy the full SHA 0ab7073View commit details -
Rollup merge of rust-lang#98708 - pinkforest:rustdoc-fix-98690, r=Gui…
…llaumeGomez rustdoc: fix 98690 Panic if invalid path for -Z persist-doctests Closes rust-lang#98690 for rustdoc panic I changed this to do eprintln and orderly panic instead of unwrap doing unhandled panic ~/gg/rust/build/x86_64-unknown-linux-gnu/stage2/bin/rustdoc --test -Z unstable-options --persist-doctests /tmp/foobar main.rs Couldn't create directory for doctest executables: Permission denied (os error 13)
Configuration menu - View commit details
-
Copy full SHA for 0fcbeb1 - Browse repository at this point
Copy the full SHA 0fcbeb1View commit details -
Rollup merge of rust-lang#98727 - notriddle:notriddle/issue-98697, r=…
…GuillaumeGomez rustdoc: filter '_ lifetimes from ty::PolyTraitRef Fixes rust-lang#98697
Configuration menu - View commit details
-
Copy full SHA for ab3d1c1 - Browse repository at this point
Copy the full SHA ab3d1c1View commit details -
Rollup merge of rust-lang#98729 - the8472:exactsize-docs, r=thomcc
clarify that ExactSizeIterator::len returns the remaining length fixes rust-lang#98721
Configuration menu - View commit details
-
Copy full SHA for d07c4c1 - Browse repository at this point
Copy the full SHA d07c4c1View commit details -
Rollup merge of rust-lang#98733 - celinval:patch-1, r=Mark-Simulacrum
Request to be notified of MIR changes Adding myself (celinval) to be notified of PRs that changes the MIR.
Configuration menu - View commit details
-
Copy full SHA for 41271f7 - Browse repository at this point
Copy the full SHA 41271f7View commit details -
Rollup merge of rust-lang#98734 - tmiasko:uninhabited-calls-release-n…
…otes, r=Mark-Simulacrum Update RELEASES.md Clarify that flow sensitive checks now understand that *visibly* uninhabited call expressions never return. The change influences checks of reachable and unreachable code alike, not just dead code like previous wording would imply. cc `@Kixunil`
Configuration menu - View commit details
-
Copy full SHA for 00cd7e8 - Browse repository at this point
Copy the full SHA 00cd7e8View commit details