Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saturated feedback controllers #273

Merged
merged 29 commits into from
Nov 10, 2023

Conversation

cmichelenstrofer
Copy link
Member

@cmichelenstrofer cmichelenstrofer commented Oct 9, 2023

Description

This PR

Type of PR

  • New feature

Checklist for PR

Additional details

Saturated PI controller has been requested multiple times. See #269

@cmichelenstrofer cmichelenstrofer changed the title Saturated feedback controllers Feedback controllers improvement: Saturation & multiple DOFs Oct 9, 2023
@ryancoe
Copy link
Collaborator

ryancoe commented Oct 10, 2023

@cmichelenstrofer - for the off-diagonal elements, are you doing anything to enforce symmetry? It'd probably be good to do this optionally.

@coveralls
Copy link

coveralls commented Oct 10, 2023

Pull Request Test Coverage Report for Build 6829198216

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 73 of 78 (93.59%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+2.0%) to 93.935%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wecopttool/pto.py 21 26 80.77%
Files with Coverage Reduction New Missed Lines %
wecopttool/core.py 2 93.45%
Totals Coverage Status
Change from base Build 6747823054: 2.0%
Covered Lines: 2478
Relevant Lines: 2638

💛 - Coveralls

@cmichelenstrofer cmichelenstrofer changed the title Feedback controllers improvement: Saturation & multiple DOFs Saturated feedback controllers Oct 16, 2023
@cmichelenstrofer
Copy link
Member Author

example notebook: saturated_pi.ipynb.zip

Copy link
Collaborator

@ryancoe ryancoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably worth a quick meeting to discuss this

wecopttool/pto.py Show resolved Hide resolved
wecopttool/pto.py Show resolved Hide resolved
tests/test_pto.py Outdated Show resolved Hide resolved
tests/test_integration.py Outdated Show resolved Hide resolved
@ryancoe ryancoe added enhancement New feature or request testing Testing, verification, etc. labels Nov 10, 2023
@ryancoe
Copy link
Collaborator

ryancoe commented Nov 10, 2023

@cmichelenstrofer - I can't seem to assign you as the reviewer for this, but can you please take a final look at what I've added in test_integration.py and then merge if you're happy?

@cmichelenstrofer cmichelenstrofer merged commit 618d7eb into sandialabs:main Nov 10, 2023
8 checks passed
@cmichelenstrofer cmichelenstrofer deleted the saturated_PI branch November 10, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Testing, verification, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: example of saturated pi controller
3 participants