Eliminate duplicate files in glob expansion #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry, I forgot to mention this change in our previous discussion. The current behavior does not check the parent directory for manifest files. For example, if the program is run from directory "/foo/bar/", `try_dirname` starts by being set to "/foo/bar/", and gets set to "/foo/" in line 259. Then, it is checked for starting with "/foo/bar/" in line 260. Since this is false, the loop only executes once. With this change, `try_dirname` starts by being set to "/foo/bar/", gets set to "/foo/", and gets checked for starting with "/foo/". The loop continues, `try_dirname` gets set to "/" and gets checked for starting with "/foo/". Then, the loop ends.
|
Not sure what's up with the MacOS CI but I'll try to fix that issue in another PR ( #451 ) If the other CI checks pass for this one, I'll merge regardless of the MacOS failure. |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.