Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate duplicate files in glob expansion #450

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Eliminate duplicate files in glob expansion #450

merged 2 commits into from
Mar 23, 2023

Commits on Mar 23, 2023

  1. Eliminate duplicate files in glob expansion

    @repr-man
    repr-man committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    cae907c View commit details
    Browse the repository at this point in the history

  2. Properly check for manifests in parent directory 

    Sorry, I forgot to mention this change in our previous discussion.  The current behavior does not check the parent directory for manifest files.
For example, if the program is run from directory "/foo/bar/", `try_dirname` starts by being set to "/foo/bar/", and gets set to "/foo/" in line 259.  Then, it is checked for starting with "/foo/bar/" in line 260.  Since this is false, the loop only executes once.
With this change, `try_dirname` starts by being set to "/foo/bar/", gets set to "/foo/", and gets checked for starting with "/foo/".  The loop continues, `try_dirname` gets set to "/" and gets checked for starting with "/foo/".  Then, the loop ends.
    @repr-man
    repr-man committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a765650 View commit details
    Browse the repository at this point in the history