Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trace): use correct roots in trace of block with one transaction #508

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Sep 11, 2023

1. Purpose or design rationale of this PR

Correctly set txStorageTrace.RootAfter in case the block only contains a single transaction.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram changed the title fix: use correct roots in trace of block with one transaction fix(trace): use correct roots in trace of block with one transaction Sep 11, 2023
@Thegaram Thegaram merged commit 9c1433b into develop Sep 11, 2023
5 checks passed
@Thegaram Thegaram deleted the fix-trace-roots branch September 11, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants