Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Open/Close actions to storage locations #221

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Conversation

sea-bass
Copy link
Owner

@sea-bass sea-bass commented Jul 17, 2024

This PR extends the Open/Close actions from just Hallway objects to also Location objects.

I don't like how much duplication there is between these 2 types of objects... but I'm inclined to handle that later.

pyrobosim_open_close_locations.mp4

Closes #208

Copy link

github-actions bot commented Jul 17, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
core
   __init__.py90100% 
   dynamics.py430100% 
   gazebo.py136894%55, 124, 230, 244–248
   hallway.py92891%192, 234–237, 261–263
   locations.py1302183%66, 68, 84, 99–100, 102, 113–114, 116–117, 134, 192, 207, 232, 242, 287, 298–299, 301–302, 331
   objects.py69494%78, 106, 137, 197
   robot.py3745485%237–238, 250–251, 254, 259, 287–290, 295–298, 305–306, 330, 374–377, 412, 450–451, 453–454, 471–473, 539–541, 650, 686, 703, 717–720, 733, 741, 747, 753, 759, 771, 814, 832, 835, 840, 853–857
   room.py48197%113
   world.py73518774%147–148, 184–185, 189, 242–243, 245–246, 274–275, 298–300, 337–339, 351–353, 382–384, 409–411, 464, 478–479, 481–482, 497–499, 515–519, 521–523, 525–526, 529, 533–537, 540–542, 545–556, 572–573, 591–593, 607–609, 645–647, 659–661, 683–685, 710–712, 760–761, 764, 780, 810–811, 822, 825, 833, 849–853, 855–857, 860–861, 864–867, 869, 872, 874–876, 878–880, 882, 897, 904, 915–919, 954–955, 959–960, 978–979, 985–986, 988–989, 991, 993–994, 996, 998–999, 1009–1010, 1013, 1015, 1029, 1031, 1038, 1085, 1116–1117, 1128, 1139–1141, 1143–1146, 1148, 1165–1166, 1170–1171, 1206–1207, 1209, 1226–1227, 1258, 1272–1275, 1287–1290, 1304, 1315–1316, 1318, 1362–1363, 1415, 1495–1496, 1542
   yaml_utils.py1081189%64, 68, 153–155, 159–160, 180–181, 200–201
gui
   __init__.py20100% 
   main.py1983184%23–25, 46, 78–79, 197, 209–213, 220–223, 225, 228–234, 238, 243–244, 248–249, 260, 271
   world_canvas.py2585678%41–42, 44–48, 51, 59–60, 138–141, 148, 150, 207–209, 256, 293, 328, 337, 343, 350–351, 353, 355–357, 360–363, 365, 369–375, 378, 381–382, 397–399, 402, 419, 462, 483, 487, 509, 526, 540
manipulation
   __init__.py10100% 
   grasping.py2366174%102, 110–112, 114–122, 124, 132, 462, 464–466, 470–472, 566–568, 571–575, 583, 586–588, 593–594, 600–604, 607–614, 617–619, 628, 630, 632–638
navigation
   __init__.py30100% 
   a_star.py781087%67–72, 74–76, 165
   execution.py85692%72–74, 79–81
   occupancy_grid.py1391489%44–47, 49–53, 56, 192, 226, 234, 238
   path_planner.py26676%33, 36, 38, 42, 85, 90
   planner_base.py593147%29–35, 51, 57–59, 86, 98, 101, 105, 113–114, 117–119, 122–124, 127, 129, 140–145
   prm.py72297%61–62
   rrt.py1740100% 
   world_graph.py70395%118, 121, 145
planning
   __init__.py00100% 
   actions.py1120100% 
planning/pddlstream
   __init__.py7185%13
   default_mappings.py90100% 
   planner.py40880%119–126
   primitives.py57394%64, 68, 208
   utils.py85396%66, 99–100
utils
   __init__.py00100% 
   general.py33487%23, 45, 51–52
   knowledge.py1481490%110, 145–148, 155, 159–160, 173, 188, 192, 234, 250, 313
   motion.py650100% 
   polygon.py1110100% 
   pose.py890100% 
   search_graph.py93396%240–242
   trajectory.py670100% 
TOTAL406155086% 

Tests Skipped Failures Errors Time
196 0 💤 0 ❌ 0 🔥 3m 1s ⏱️

@sea-bass sea-bass merged commit ad2ad46 into main Jul 17, 2024
7 checks passed
@sea-bass sea-bass deleted the open-close-locations branch July 17, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Open/Close actions to storage locations
1 participant