chore(js/ts): allow ellipses to occur in jsx elements #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonspark
requested review from
aryx,
IagoAbal and
mjambon
and removed request for
a team
aryx
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
LGTM.
Actually we currently have some implicit "..." in JSX attributes; even if you don't
use a ..., we match like there is some "...". I always wanted to force people
to add "...", to be more consistent, but never took the time because of fear of breaking existing rules.
Nore sure what's going on with CI though.
maybe @mjambon know.
|
@aryx i believe it's spurious, see the job: |
mjambon
added a commit
that referenced
this pull request
Sep 13, 2024
mjambon
added a commit
that referenced
this pull request
Sep 13, 2024
mjambon
added a commit
that referenced
this pull request
Sep 17, 2024
mjambon
added a commit
that referenced
this pull request
Sep 18, 2024
* Use new OCaml code generator and runtime with support for extras * Add lists of languages that need this or that version of tree-sitter. * Fix gitignore * Update core submodule * Add missing languages to lists of languages * Add missing language * Restore version of tree-sitter-julia supported by semgrep * Update core, requires regenerating all languages * Add lists of languages for the 'release' command * Add readme * Undo PR #488 because the corresponding changes weren't made in semgrep * Revert 2 recent semgrep-go commits by Brandon and Yosef because the accompanying changes in semgrep are not ready. We're reverting the contents of semgrep-go to commit 9b59bf4 * Update core * Promote html parser from tree-sitter 0.20.6 to 0.22.6 * Use a patched version of tree-sitter-vue that avoids HTML parsing errors in programs where both semgrep-vue and semgrep-html are used. * Add safeguard against running into the same tree-sitter-vue issue again * Update core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
This PR also fixes the Makefile to also include the name of the dialect that it is dealing with. Previously it only printed the PWD.
Security