Update the ocaml-tree-sitter runtime library #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the accompanying changes in semgrep are not ready. We're reverting the contents of semgrep-go to commit 9b59bf4
in programs where both semgrep-vue and semgrep-html are used.
aryx
approved these changes
Sep 18, 2024
|
@yosefAlsuhaibani @brandonspark once this is merged you will need to restore your improvements to semgrep-go and other |
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Sep 18, 2024
…oprietary#2260) This changes the type of tree-sitter parsing results. This required regenerating all the grammars. Passing CI tests with this pull requests validates the other two pull requests: * semgrep/ocaml-tree-sitter-core#48 * semgrep/ocaml-tree-sitter-semgrep#510 test plan: `make test` synced from Pro bc3fa2e1e2838941e3860d422569ca6a35826b15
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Sep 19, 2024
…oprietary#2260) This changes the type of tree-sitter parsing results. This required regenerating all the grammars. Passing CI tests with this pull requests validates the other two pull requests: * semgrep/ocaml-tree-sitter-core#48 * semgrep/ocaml-tree-sitter-semgrep#510 test plan: `make test` synced from Pro bc3fa2e1e2838941e3860d422569ca6a35826b15
nmote
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Sep 19, 2024
…oprietary#2260) This changes the type of tree-sitter parsing results. This required regenerating all the grammars. Passing CI tests with this pull requests validates the other two pull requests: * semgrep/ocaml-tree-sitter-core#48 * semgrep/ocaml-tree-sitter-semgrep#510 test plan: `make test` synced from Pro bc3fa2e1e2838941e3860d422569ca6a35826b15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This required reverting changes for the following languages because the Semgrep integration wasn't in sync:
There was also a tricky bug occurring only in Semgrep which was due to tree-sitter-vue which was solved by patching tree-sitter-vue (it was declaring
tree_sitter_html_*functions that were apparently picked by the linker instead of the real tree-sitter-html functions). Here's the modified version of tree-sitter-vue we're now using: ikatyang/tree-sitter-vue#30. I added a safeguard so that future updates of the tree-sitter-vue submodule fail gracefully if sometree_sitter_html_*functions make a comeback.The accompanying pull requests are:
On my machine, regenerating the Hack grammar takes 16.4 GB of RAM. C# is the second biggest memory consumer with 14.2 GB.
Checklist