chore: Upgrade absl and protobuf (#1337)

protobuf depends on absl, so both needed an update.

Updating absl fixes issues on Alpine 3.19 (see PR #1327), and also
removes the need for hacks around vlog flags.

packager/CMakeLists.txt

@@ -170,8 +170,6 @@ add_executable(packager
   app/stream_descriptor.h
   app/validate_flag.cc
   app/validate_flag.h
-  app/vlog_flags.cc
-  app/vlog_flags.h
   app/widevine_encryption_flags.cc
   app/widevine_encryption_flags.h
 )
@@ -190,8 +188,6 @@ target_link_libraries(packager
 add_executable(mpd_generator
   app/mpd_generator.cc
   app/mpd_generator_flags.h
-  app/vlog_flags.cc
-  app/vlog_flags.h
 )
 target_link_libraries(mpd_generator
   absl::flags

packager/app/mpd_generator.cc

@@ -21,7 +21,6 @@
 #include <absl/strings/str_split.h>
 
 #include <packager/app/mpd_generator_flags.h>
-#include <packager/app/vlog_flags.h>
 #include <packager/mpd/util/mpd_writer.h>
 #include <packager/tools/license_notice.h>
 #include <packager/version/version.h>
@@ -124,8 +123,6 @@ int MpdMain(int argc, char** argv) {
     return status;
   }
 
-  handle_vlog_flags();
-
   absl::InitializeLog();
 
   if (!absl::GetFlag(FLAGS_test_packager_version).empty())

packager/app/packager_main.cc

@@ -34,7 +34,6 @@
 #include <packager/app/raw_key_encryption_flags.h>
 #include <packager/app/retired_flags.h>
 #include <packager/app/stream_descriptor.h>
-#include <packager/app/vlog_flags.h>
 #include <packager/app/widevine_encryption_flags.h>
 #include <packager/file.h>
 #include <packager/kv_pairs/kv_pairs.h>
@@ -564,8 +563,6 @@ int PackagerMain(int argc, char** argv) {
     absl::SetMinLogLevel(absl::LogSeverityAtLeast::kWarning);
   }
 
-  handle_vlog_flags();
-
   absl::InitializeLog();
 
   if (!ValidateWidevineCryptoFlags() || !ValidateRawKeyCryptoFlags() ||

packager/macros/logging.h

@@ -14,20 +14,4 @@
 /// You can use the insertion operator to add specific logs to this.
 #define NOTIMPLEMENTED() LOG(ERROR) << "NOTIMPLEMENTED: "
 
-#define VLOG(verboselevel) \
-  LOG(LEVEL(static_cast<absl::LogSeverity>(-verboselevel)))
-
-#define VLOG_IS_ON(verboselevel) \
-  (static_cast<int>(absl::MinLogLevel()) <= -verboselevel)
-
-#ifndef NDEBUG
-#define DVLOG(verboselevel) VLOG(verboselevel)
-#else
-// We need this expression to work with << after it, so this is a simple way to
-// turn DVLOG into a no-op in release builds.
-#define DVLOG(verboselevel) \
-  if (false)                \
-  VLOG(verboselevel)
-#endif
-
 #endif  // PACKAGER_MACROS_LOGGING_H_

packager/third_party/abseil-cpp/CMakeLists.txt

@@ -13,5 +13,8 @@ set(ABSL_PROPAGATE_CXX_STD ON)
 # for one in the system.
 set(ABSL_USE_EXTERNAL_GOOGLETEST ON)
 
+# Disable internal debugging features.
+add_definitions(-DNDEBUG)
+
 # With these set in scope of this folder, load the library's own CMakeLists.txt.
 add_subdirectory(source)

packager/third_party/protobuf/CMakeLists.txt

@@ -25,8 +25,7 @@ set(ABSL_ROOT_DIR get_filename_component(ABSOLUTE_PATH ../abseil-cpp/source ABSO
 # Make sure protoc links against the same MSVC runtime as internal libs.
 set(protobuf_MSVC_STATIC_RUNTIME OFF)
 
-# Disable internal debugging features, which end up triggering further compiler
-# errors.
+# Disable internal debugging features.
 add_definitions(-DNDEBUG)
 
 # With these set in scope of this folder, load the library's own CMakeLists.txt.