chore: Upgrade absl and protobuf #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmin
approved these changes
Feb 9, 2024
|
Shall we revisit treating warnings as errors in 3rd party deps? It seems like a constant game of whack-a-mole every time we upgrade deps or toolchain. |
|
Yes, I think you're right. At the time I started down this path, I wanted to avoid any surprise warnings that might be meaningful things we should take action on... but third_party is big and we are not really reviewing them. |
protobuf depends on absl, so both needed an update. Updating absl fixes issues on Alpine 3.19 (see PR shaka-project#1327), and also removes the need for hacks around vlog flags.
joeyparrish
force-pushed
the
upgrade-absl
branch
from
952b02d
to
6f626f3
Compare
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobuf depends on absl, so both needed an update.
Updating absl fixes issues on Alpine 3.19 (see PR #1327), and also removes the need for hacks around vlog flags.