Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MediumLinearMotor (#88008) as a Device #102

Closed
corneliusmunz opened this issue Oct 11, 2020 · 3 comments · Fixed by #105
Closed

Add MediumLinearMotor (#88008) as a Device #102

corneliusmunz opened this issue Oct 11, 2020 · 3 comments · Fixed by #105
Assignees
@corneliusmunz
Labels
area-devices enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
v3.1 (non-breaking)

Comments

@corneliusmunz
Copy link
Contributor

Add the DeviceType ExternalMotorWithTacho aka MediumLinearMotor (88008) to the list of supported devices
@corneliusmunz
Copy link
Contributor Author

Result of poweredup device dump-static-port

Discover Port 0. Receiving Messages ...
........................
Discover Ports Function: 23 / 23
##################################################
0B-00-43-00-01-07-03-06-00-07-00
07-00-43-00-02-06-00
12-00-44-00-00-00-50-4F-57-45-52-00-00-00-00-00-00-00
0E-00-44-00-00-01-00-00-C8-C2-00-00-C8-42
0E-00-44-00-00-02-00-00-C8-C2-00-00-C8-42
0E-00-44-00-00-03-00-00-C8-C2-00-00-C8-42
0B-00-44-00-00-04-50-43-54-00-00
08-00-44-00-00-05-00-10
0A-00-44-00-00-80-01-00-01-00
12-00-44-00-01-00-53-50-45-45-44-00-00-00-00-00-00-00
0E-00-44-00-01-01-00-00-C8-C2-00-00-C8-42
0E-00-44-00-01-02-00-00-C8-C2-00-00-C8-42
0E-00-44-00-01-03-00-00-C8-C2-00-00-C8-42
0B-00-44-00-01-04-50-43-54-00-00
08-00-44-00-01-05-10-10
0A-00-44-00-01-80-01-00-04-00
12-00-44-00-02-00-50-4F-53-00-00-00-00-00-00-00-00-00
0E-00-44-00-02-01-00-00-B4-C3-00-00-B4-43
0E-00-44-00-02-02-00-00-C8-C2-00-00-C8-42
0E-00-44-00-02-03-00-00-B4-C3-00-00-B4-43
0B-00-44-00-02-04-44-45-47-00-00
08-00-44-00-02-05-08-08
0A-00-44-00-02-80-01-02-04-00
##################################################

@tthiery
Copy link
Member

tthiery commented Oct 11, 2020

Are you implementing this one? If so, assign this to yourself ;)

@tthiery tthiery added enhancement New feature or request good first issue Good for newcomers area-devices help wanted Extra attention is needed labels Oct 11, 2020
@corneliusmunz
Copy link
Contributor Author

@tthiery Implemented and tested in PR #105

@tthiery tthiery mentioned this issue Oct 12, 2020
Merged
@tthiery tthiery added this to the v3.1 (non-breaking) milestone Oct 12, 2020
tthiery pushed a commit that referenced this issue Oct 12, 2020
@corneliusmunz
Add MediumLinearMotor (#105)
bcc2065 
#102 non-breaking (API extension, enum rename fine w/o usage)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corneliusmunz corneliusmunz

Labels
area-devices enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
v3.1 (non-breaking)
Development

Successfully merging a pull request may close this issue.

Feature/add medium linear motor corneliusmunz/powered-up
2 participants
@tthiery @corneliusmunz