Feature/add medium linear motor #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthiery
approved these changes
Oct 12, 2020
| @@ -15,7 +15,7 @@ public enum DeviceType : ushort | |||
| ExternalTiltSensor = 0x0022, // TILT_SENSOR | |||
| MotionSensor = 0x0023, // MOTION_SENSOR | |||
| VisionSensor = 0x0025, // COLOR_DISTANCE_SENSOR | |||
| ExternalMotorWithTacho = 0x0026, // MEDIUM_LINEAR_MOTOR | |||
| MediumLinearMotor = 0x0026, // MEDIUM_LINEAR_MOTOR | |||
There was a problem hiding this comment.
Naming choice is perfect. I copied these from poweredup-node ... but they have history.
Normally, this would apply for a breaking change. But honestly, the motor is not implemented so I cannot imagine why someone would use this enum value.
Therefore, fine with me!
|
|
||
| namespace Example | ||
| { | ||
| public class ExampleTwoPortHubMediumLinearMotor : BaseExample |
There was a problem hiding this comment.
I usually add the test run to the Program.cs commented out ... like that it can be easier discovered. Fix it on the next PR.
There was a problem hiding this comment.
Ok, good idea! Will take care of that in the next PR
|
Closes #102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested this one with the TwoPort Hub and the MediumLinear Motor. I have changed the naming of the DeviceType from ExternalMotorWithTacho to MediumLinearMotor according to the Lego naming. Hope that is ok.
Closes #102