Handle unlinked tempfiles in Shrine#upload

Fixes #563
shrinerb · Feb 19, 2022 · d21556f · d21556f
1 parent b0f5624
commit d21556f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/shrine.rb b/lib/shrine.rb
@@ -252,7 +252,7 @@ def _upload(io, location:, metadata:, upload_options: {}, close: true, delete: f
     def extract_filename(io)
       if io.respond_to?(:original_filename)
         io.original_filename
-      elsif io.respond_to?(:path)
+      elsif io.respond_to?(:path) && io.path
         File.basename(io.path)
       end
     end

diff --git a/test/shrine_test.rb b/test/shrine_test.rb
@@ -434,6 +434,13 @@ def respond_to_missing?(name, include_private = false)
 
       @uploader.upload(io)
     end
+
+    it "supports unlinked tempfiles" do
+      tempfile = Tempfile.new
+      tempfile.unlink
+
+      assert_kind_of Shrine::UploadedFile, @uploader.upload(tempfile)
+    end
   end
 
   describe "#generate_location" do