Move all error diagnostics to _errors #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pan <a@tny.town>
tnytown
commented
Mar 7, 2023
tnytown
force-pushed
the
andrew/exception-handling-la-deuxieme
branch
from
bb9800c
to
80d5408
Compare
|
Sigh, ok. I will need to definitively figure out the circular import issue. |
Signed-off-by: William Woodruff <william@yossarian.net>
tetsuo-cpp
reviewed
Mar 9, 2023
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Alex Cameron <asc@tetsuo.sh>
Signed-off-by: Andrew Pan <a@tny.town>
tnytown
force-pushed
the
andrew/exception-handling-la-deuxieme
branch
from
92a6168
to
1c3813c
Compare
Signed-off-by: Andrew Pan <a@tny.town>
tnytown
force-pushed
the
andrew/exception-handling-la-deuxieme
branch
from
1c3813c
to
2f6ffb7
Compare
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
|
newly failing because of a recently introduced lint in bandit. |
|
Blocked on #541. |
woodruffw
reviewed
Mar 11, 2023
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
reviewed
Mar 13, 2023
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the work mentioned in #525. I grepped for
dedentand moved all user-facing error messages to subclasses ofErrorw/ thediagnosticsmethod.Depends on #525, that should be merged first.
Release Note
(Same as #525)