Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc: configure timeouts for requests #541

Merged
merged 2 commits into from
Mar 11, 2023
Merged

oidc: configure timeouts for requests #541

merged 2 commits into from
Mar 11, 2023

Conversation

tnytown
Copy link
Collaborator

@tnytown tnytown commented Mar 11, 2023

Summary

Bandit recently released v1.7.5, which includes a new lint for requests usage without a timeout. This changeset fixes our usage of requests in oidc.

@tnytown
oidc: configure timeouts for requests
1803a74 
Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown mentioned this pull request Mar 11, 2023
Merged
@tnytown tnytown requested a review from tetsuo-cpp March 11, 2023 20:53
woodruffw
woodruffw reviewed Mar 11, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also handle the Timeout exception, now that we're explicitly handling the timeout case.

(We should have been doing this before, but now's a good opportunity to address it.)

@tnytown
oidc, _errors: handle requests.Timeout
91adcb4 
Signed-off-by: Andrew Pan <a@tny.town>
woodruffw
woodruffw approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@woodruffw woodruffw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@woodruffw woodruffw merged commit d544abe into sigstore:main Mar 11, 2023
@woodruffw woodruffw deleted the andrew/requests-timeout branch March 11, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woodruffw woodruffw woodruffw approved these changes

@tetsuo-cpp tetsuo-cpp Awaiting requested review from tetsuo-cpp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnytown @woodruffw