Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-store needs to update for Typescript 4.7 #222

Closed
sandersn opened this issue Apr 20, 2022 · 0 comments · Fixed by #223
Closed

electron-store needs to update for Typescript 4.7 #222

sandersn opened this issue Apr 20, 2022 · 0 comments · Fixed by #223

Comments

@sandersn
Copy link
Contributor

It needs to pull in sindresorhus/type-fest#388 and sindresorhus/conf#163, and update its Options type with the same T extends Record<string, any> constraint.
sandersn added a commit to sandersn/electron-store that referenced this issue Apr 20, 2022
@sandersn
Update Options type parameter constraint for TS 4.7
e9d9a66 
Options's type parameter is passed to conf's Options type, which
requires is constrained to `Record<string, any>`. Typescript 4.7 will
properly check this constraint where it didn't before.

Fixes sindresorhus#222

Depends on fixes: sindresorhus/type-fest#388 and sindresorhus/conf#163
@sandersn sandersn mentioned this issue Apr 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Options type parameter constraint for TS 4.7 sandersn/electron-store
1 participant
@sandersn