Update get.d.ts for TS 4.7 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Callers of `WithStringKeys` pass in an unconstrained type parameter, and `StringKeyOf` uses an unconstrained type parameter, so `WithStringKeys` should handle an unconstrained type parameter. TS 4.7 calls out this inconsistency.
|
Thanks :) |
sandersn
added a commit
to sandersn/electron-store
that referenced
this pull request
Apr 20, 2022
Options's type parameter is passed to conf's Options type, which requires is constrained to `Record<string, any>`. Typescript 4.7 will properly check this constraint where it didn't before. Fixes sindresorhus#222 Depends on fixes: sindresorhus/type-fest#388 and sindresorhus/conf#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers of
WithStringKeyspass in an unconstrained type parameter, andStringKeyOfuses an unconstrained type parameter, soWithStringKeysshould handle an unconstrained type parameter. TS 4.7 calls out this inconsistency.