Fix NPE if dismiss() is called before show() #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to
v2.2+
gives me this crash:I have a database listener which only knows if a user has tapped a prompt or not. I use an observable model that shows or dismisses the prompt based on that boolean flag. Thus, I have no knowledge of the current state of the prompt, just the state it should be in. This means I'll be possibly calling
dismiss()
beforeshow()
which causes the above NPE.To fix this problem, we now save our current state instead of the limited
mDismissing
field. In addition, I've added agetState()
method though that isn't necessary to fix the bug.