Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ISE when trying to show prompt while it's dismissing #89

Merged
merged 2 commits into from
Nov 14, 2017
Merged

Fix ISE when trying to show prompt while it's dismissing #89

merged 2 commits into from
Nov 14, 2017

Conversation

SUPERCILEX
Copy link
Contributor

Similar to #87, but this time the ViewGroup would blow up saying the prompt view was already added. This PR hardens the show() method even further to reset the prompt if it's currently dismissing.

In addition, it removes broken onAnimationCancel methods. The animator lifecycle guarantees that onAnimationEnd will be called even if onAnimationCancel is also called.

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #89 into master will increase coverage by 0.84%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #89      +/-   ##
===========================================
+ Coverage     93.56%   94.4%   +0.84%     
- Complexity      309     311       +2     
===========================================
  Files            14      14              
  Lines          1025    1019       -6     
  Branches        117     118       +1     
===========================================
+ Hits            959     962       +3     
+ Misses           39      30       -9     
  Partials         27      27
Impacted Files Coverage Δ Complexity Δ
...terialtaptargetprompt/MaterialTapTargetPrompt.java 86.94% <100%> (+2.76%) 32 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18a0f58...341c134. Read the comment docs.

@sjwall
Copy link
Owner

sjwall commented Nov 12, 2017

Hey, thanks for your work and the PR. I haven't had chance to review it yet but will do tomorrow

@SUPERCILEX
Copy link
Contributor Author

NP!

@sjwall sjwall merged commit 40bc310 into sjwall:master Nov 14, 2017
@sjwall
Copy link
Owner

sjwall commented Nov 14, 2017

Changes look good. Thanks again for your work! Changes have been released in v2.4.1

@SUPERCILEX
Copy link
Contributor Author

Awesome, thanks!

@SUPERCILEX SUPERCILEX deleted the ise branch November 14, 2017 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants