"Reset" button in UI #7406
Merged
"Reset" button in UI #7406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
ce3bfb1
to
5a03d79
Compare
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
5a03d79
to
090dd85
Compare
samsondav
force-pushed
the
feature/sc-43120-2
branch
2 times, most recently
from
e5c172b
to
be8ed81
Compare
Alejandro-Larumbe
previously approved these changes
Sep 12, 2022
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
be8ed81
to
e730b27
Compare
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
b12f7bd
to
408b674
Compare
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
3b6459b
to
ea2e084
Compare
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
ea2e084
to
88e7b26
Compare
samsondav
force-pushed
the
feature/sc-43120-2
branch
from
8dbcf3c
to
0e67293
Compare
jmank88
reviewed
Sep 13, 2022
| @@ -109,6 +109,7 @@ func (ks *eth) Create(chainIDs ...*big.Int) (ethkey.KeyV2, error) { | |||
| if err == nil { | |||
| ks.notify() | |||
| } | |||
| ks.logger.Infow(fmt.Sprintf("Created EVM key with ID %s", key.Address.Hex()), "address", key.Address.Hex(), "evmChainIDs", chainIDs) | |||
There was a problem hiding this comment.
What format does chainIDs get logged in? JSON array?
Might we later get annoyed by the plural key name evmChainIDs when trying to filter logs by keys and evmChainID doesn't match this?
There was a problem hiding this comment.
Yes, JSON array.
I think the plural is ok.
jmank88
approved these changes
Sep 13, 2022
This was referenced Mar 13, 2023
This was referenced Mar 24, 2023
This was referenced May 11, 2023
This was referenced May 23, 2023
This was referenced Jul 20, 2023
This was referenced Aug 17, 2023
This was referenced Oct 20, 2023
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Reset" button in admin UI allows configuring key/chain.
