-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Reset" button in UI #7406
Merged
Merged
"Reset" button in UI #7406
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
cbe4273
Key admin button in UI
samsondav cb532f5
Address PR feedback
samsondav 88e7b26
Fix frontend tests
samsondav 1349cad
Try queryAllByText
samsondav 09217e5
Merge branch 'develop' into feature/sc-43120-2
samsondav 725c139
Try queryAllByText
samsondav 0e67293
Merge branch 'feature/sc-43120-2' of github.com:smartcontractkit/chai…
samsondav 1129deb
Merge branch 'develop' into feature/sc-43120-2
samsondav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import * as jsonapi from 'utils/json-api-client' | ||
import { boundMethod } from 'autobind-decorator' | ||
import * as models from 'core/store/models' | ||
|
||
export const ENDPOINT = '/v2/keys/evm/chain' | ||
|
||
export class EVMKeys { | ||
constructor(private api: jsonapi.Api) {} | ||
|
||
@boundMethod | ||
public chain( | ||
request: models.EVMKeysChainRequest, | ||
): Promise<jsonapi.ApiResponse<models.EVMKey>> { | ||
const query = new URLSearchParams() | ||
|
||
query.append('address', request.address) | ||
query.append('evmChainID', request.evmChainID) | ||
if (request.nextNonce !== null) { | ||
query.append('nextNonce', request.nextNonce) | ||
} | ||
if (request.abandon !== null) { | ||
query.append('abandon', String(request.abandon)) | ||
} | ||
if (request.enabled !== null) { | ||
query.append('enabled', String(request.enabled)) | ||
} | ||
|
||
const endpoint = ENDPOINT + '?' + query.toString() | ||
|
||
return this.api.createResource<models.EVMKeysChainRequest, models.EVMKey>( | ||
endpoint, | ||
)() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What format does
chainIDs
get logged in? JSON array?Might we later get annoyed by the plural key name
evmChainIDs
when trying to filter logs by keys andevmChainID
doesn't match this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, JSON array.
I think the plural is ok.