fix: use current location as base url for form action #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsMapleLeaf
added
🐛 bug
smeijer
reviewed
Sep 23, 2021
itsMapleLeaf
force-pushed
the
form-action-url-error
branch
from
cf201da
to
eb6c821
Compare
smeijer
reviewed
Sep 23, 2021
itsMapleLeaf
force-pushed
the
form-action-url-error
branch
from
eb6c821
to
c381a33
Compare
If the end user doesn't have the types installed for the libraries we require, they could potentially end up with any types. Using a wide major version to share the user's local types version if they installed them
itsMapleLeaf
force-pushed
the
form-action-url-error
branch
from
c381a33
to
a1ced99
Compare
smeijer
changed the title
|
Thanks! Published https://github.com/smeijer/next-runtime/releases/tag/v2.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to use the
actionattribute withFormraises an error. Thenew URLconstructor also needs a base URL if just being passed a path, which serves as the "fallback" of whatever's incomplete in the first arg. Sonew URL('/somepath', window.location.href)should come out tohttps://localhost:4000/somepath(assuming localhost 4k)Also includes some generic type fixes and improvements