feat: Add an iterator selection function #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Thanks!
rand also has similar methods that return Option, so I think this API is good as is.
rand's choose/choose_stable also supports iterators that do not implement ExactSizeIterator, but given that the imprecision of size_hint complicate the implementation, it seems reasonable that we support only ExactSizeIterator.
(P.S., I closed and reopened PR to trigger CI)
Merged
notgull
added a commit
that referenced
this pull request
Jun 9, 2023
- **Breaking:** Remove interior mutability from `Rng`. (#47) - Add a `fork()` method. (#49) - Add a `no_std` mode. (#50) - Add an iterator selection function. (#51) - Add a `choose_multiple()` function for sampling several elements from an iterator. (#55) - Use the `getrandom` crate for seeding on WebAssembly targets if the `js` feature is enabled. (#60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an iterator selection function,
choice(), that takes anExactSizeIteratorand chooses a random value from it. In addition, I reimplement functions likealphanumeric()usingchoice().Right now, the API returns
Option<I::Item>, since an iterator could be empty. However, it may be slightly more idiomatic to have it returnI::Itemand panic if given an empty/buggy iterator.