Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 #59

Merged
merged 1 commit into from
Jun 9, 2023
Merged

v2.0.0 #59

merged 1 commit into from
Jun 9, 2023

Conversation

notgull
Copy link
Member

@notgull notgull commented Apr 7, 2023

@notgull
Copy link
Member Author

notgull commented Apr 7, 2023

As this is a breaking release, we should probably consider if there are any other breaking changes that we want to make before we release.

@notgull
Copy link
Member Author

notgull commented May 10, 2023

@smol-rs/admins Any objections to publishing this?

@taiki-e
Copy link
Collaborator

taiki-e commented May 13, 2023

I was thinking of replacing the dependency on instant or making it easier to use. Currently, instant is virtually a public dependency as the user has to directly depend on instant to enable the wasm-bindgen feature.

Specifically, I was thinking of either providing something like a wasm-bindgen feature that would enable the wasm-bindgen feature of instant, or providing similar features by directly depending on wasm-bindgen (i.e., drop instant). Probably, it is also okay to start with the former and switch to the latter, though.

That said, I don't have the bandwidth to work on it right now, so if other admins are happy with the current wasm-unknown-unknown support situation, I'm fine with that.

@SilvanCodes
Copy link

Looking forward to use fastrand with Sync and choice!

@notgull
Copy link
Member Author

notgull commented Jun 8, 2023

Alright, any other objections? @smol-rs/admins

@taiki-e
Copy link
Collaborator

taiki-e commented Jun 8, 2023

LGTM. Would you update the changelog to include #60?

@notgull notgull merged commit 6315dd1 into master Jun 9, 2023
@notgull notgull deleted the notgull/next branch June 9, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants