-
Notifications
You must be signed in to change notification settings - Fork 437
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Backport 1.17 Move glooctl and gloomtls tests to new framework (#9777)
* cherrypick gloomtls tests * Move glooctl tests to new framework (#9718) * initial move for glooctl tests * combine glooctl helm manifest and edge gw manifest * fix check crds * move test helper values in glooContext * fix crd check for not gloo-system ns * passing tests * passing eventually error test * changelog, cleanup * update references to old glooctl tests * regen docs * remove old glooctl test from workflow * Adding changelog file to new location * Deleting changelog file from old location * fix race debug * remove old glooctl tests from nightlys * Adding changelog file to new location * Deleting changelog file from old location * Add back nightlys for 1.15 and 1.16 * add glooctl tests back * remove tmp dir for check-crds * Adding changelog file to new location * Deleting changelog file from old location * istio feedback from prev pr * helm manifest typo * chart uri --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: changelog-bot <changelog-bot> * changelog * remove unnecessary workflow changes * combine changelogs --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Sam Heilbron <SamHeilbron@gmail.com>
- Loading branch information
1 parent
751e637
commit 17ebe72
Showing
43 changed files
with
1,018 additions
and
115 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
changelog: | ||
- type: NON_USER_FACING | ||
issueLink: https://github.com/solo-io/solo-projects/issues/6303 | ||
resolvesIssue: false | ||
description: >- | ||
Migrate glooctl tests from kube2e to new framework. | ||
skipCI-docs-build:true | ||
- type: NON_USER_FACING | ||
issueLink: https://github.com/solo-io/solo-projects/issues/6303 | ||
resolvesIssue: false | ||
description: >- | ||
Migrate gloomtls tests from kube2e to new framework. | ||
skipCI-docs-build:true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package glooctl | ||
|
||
import ( | ||
"context" | ||
|
||
"github.com/solo-io/gloo/test/kubernetes/e2e" | ||
"github.com/stretchr/testify/suite" | ||
) | ||
|
||
var _ e2e.NewSuiteFunc = NewDebugSuite | ||
|
||
// checkCrdsSuite contains the set of tests to validate the behavior of `glooctl check-crds` | ||
type checkCrdsSuite struct { | ||
suite.Suite | ||
|
||
ctx context.Context | ||
testInstallation *e2e.TestInstallation | ||
} | ||
|
||
func NewCheckCrdsSuite(ctx context.Context, testInst *e2e.TestInstallation) suite.TestingSuite { | ||
return &checkCrdsSuite{ | ||
ctx: ctx, | ||
testInstallation: testInst, | ||
} | ||
} | ||
|
||
func (s *checkCrdsSuite) TestValidatesCorrectCrds() { | ||
if s.testInstallation.Metadata.ReleasedVersion != "" { | ||
err := s.testInstallation.Actions.Glooctl().CheckCrds(s.ctx, | ||
"-n", s.testInstallation.Metadata.InstallNamespace, | ||
"--kube-context", s.testInstallation.ClusterContext.KubeContext, | ||
"--version", s.testInstallation.Metadata.ChartVersion) | ||
s.NoError(err) | ||
} else { | ||
err := s.testInstallation.Actions.Glooctl().CheckCrds(s.ctx, | ||
"-n", s.testInstallation.Metadata.InstallNamespace, | ||
"--kube-context", s.testInstallation.ClusterContext.KubeContext, | ||
"--local-chart", s.testInstallation.Metadata.ChartUri) | ||
s.NoError(err) | ||
} | ||
} | ||
|
||
func (s *checkCrdsSuite) TestCrdMismatch() { | ||
err := s.testInstallation.Actions.Glooctl().CheckCrds(s.ctx, | ||
"-n", s.testInstallation.Metadata.InstallNamespace, | ||
"--kube-context", s.testInstallation.ClusterContext.KubeContext, | ||
"--version", "1.9.0") | ||
s.Error(err) | ||
s.Contains(err.Error(), "One or more CRDs are out of date") | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.