Move glooctl tests to new framework

[npolshakova]

Description

Adds new Glooctl tests in new framework. These tests can run for k8s Gateway and Edge Gateway apis.

API changes

None

Code changes

• Small fix to check-crds to allow it to work in namespaces other than gloo-system
• Small fix for datarace detected in debug tests:

Full logs

2024-07-08T16:38:16.7127482Z === RUN   TestGlooctlGlooGatewayEdgeGateway/Debug/TestLogsFile
2024-07-08T16:38:16.8222549Z ==================
2024-07-08T16:38:16.8223316Z WARNING: DATA RACE
2024-07-08T16:38:16.8224319Z Write at 0x00c0041db450 by goroutine 34873:
2024-07-08T16:38:16.8225734Z   github.com/solo-io/gloo/projects/gloo/cli/pkg/cmd/debug.DebugLogs.func1()
2024-07-08T16:38:16.8227720Z       /home/runner/work/gloo/gloo/projects/gloo/cli/pkg/cmd/debug/debug.go:62 +0x5ce
2024-07-08T16:38:16.8229096Z   golang.org/x/sync/errgroup.(*Group).Go.func1()
2024-07-08T16:38:16.8230659Z       /home/runner/go/pkg/mod/golang.org/x/sync@v0.6.0/errgroup/errgroup.go:78 +0x91
2024-07-08T16:38:16.8231561Z 
2024-07-08T16:38:16.8232047Z Previous write at 0x00c0041db450 by goroutine 34874:
2024-07-08T16:38:16.8233505Z   github.com/solo-io/gloo/projects/gloo/cli/pkg/cmd/debug.DebugLogs.func1()
2024-07-08T16:38:16.8235616Z       /home/runner/work/gloo/gloo/projects/gloo/cli/pkg/cmd/debug/debug.go:62 +0x5ce
2024-07-08T16:38:16.8237141Z   golang.org/x/sync/errgroup.(*Group).Go.func1()
2024-07-08T16:38:16.8238628Z       /home/runner/go/pkg/mod/golang.org/x/sync@v0.6.0/errgroup/errgroup.go:78 +0x91
2024-07-08T16:38:16.8239578Z 
2024-07-08T16:38:16.8239869Z Goroutine 34873 (running) created at:
2024-07-08T16:38:16.8240899Z   golang.org/x/sync/errgroup.(*Group).Go()
2024-07-08T16:38:16.8242349Z       /home/runner/go/pkg/mod/golang.org/x/sync@v0.6.0/errgroup/errgroup.go:75 +0x124
2024-07-08T16:38:16.8243971Z   github.com/solo-io/gloo/projects/gloo/cli/pkg/cmd/debug.DebugLogs()
2024-07-08T16:38:16.8245761Z       /home/runner/work/gloo/gloo/projects/gloo/cli/pkg/cmd/debug/debug.go:52 +0x528
2024-07-08T16:38:16.8247364Z   github.com/solo-io/gloo/projects/gloo/cli/pkg/cmd/debug.DebugLogCmd.func1()
2024-07-08T16:38:16.8249010Z       /home/runner/work/gloo/gloo/projects/gloo/cli/pkg/cmd/debug/root.go:34 +0x48
2024-07-08T16:38:16.8250119Z   github.com/spf13/cobra.(*Command).execute()

CI changes

• Added new e2e tests for k8s gateway and edge gateway glooctl tests
• Removed glooctl tests from old K8s suite

Docs changes

None

Context

Part of moving kube2e tests to new framework

Interesting decisions

The helm manifest requires this set for the glooctl error checks to be correctly handled:

  validation:
    # These tests validate the glooctl properly reports errors and warnings on resources
    # Therefore, we accept all resources in our webhook
    alwaysAcceptResources: true

There is also a new Edge Gateway defined in the helm chart for test parity:

gatewayProxies:
  publicGw: # Proxy name for public access (Internet facing)
    disabled: false # overwrite the "default" value in the merge step
    kind:
      deployment:
        replicas: 2
    service:
      kubeResourceOverride: # workaround for https://github.com/solo-io/gloo/issues/5297
        spec:
          ports:
            - port: 443
              protocol: TCP
              name: https
              targetPort: 8443
          type: LoadBalancer
    gatewaySettings:
      customHttpsGateway: # using the default HTTPS Gateway
        virtualServiceSelector:
          gateway-type: public # label set on the VirtualService
      disableHttpGateway: true # disable the default HTTP Gateway

The K8s Glooctl manifest does not disable the default Edge proxy to test that the expected checks still pass when both are enabled.

Testing steps

• Ran new e2e tests locally to confirm behavior with Gloo Edge Gateway and k8s Gateway

Notes for reviewers

None

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

[solo-changelog-bot]

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6303

[github-actions]

Visit the preview URL for this PR (updated for commit 258d7ea):

https://gloo-edge--pr9718-npolshak-glooctl-tes-issu9i2k.web.app

_{(expires Fri, 12 Jul 2024 21:27:17 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 77c2b86e287749579b7ff9cadb81e099042ef677}