iosnapshot/history: fix test flake #9630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
keep pr updated
lgadban
approved these changes
Jun 17, 2024
sam-heilbron
added a commit
that referenced
this pull request
Jun 20, 2024
* fix test flake * add changelog * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
4 tasks
soloio-bulldozer bot
added a commit
that referenced
this pull request
Jun 20, 2024
* iosnapshot/history: fix test flake (#9630) * fix test flake * add changelog * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * helm: support webhook.enablePolicyApi (#9632) * update helm api and docs * bad . * more restrictive check * add test case * add changelog * undo debugging step * update helm api description * improve helm description --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * introduce test coverage reporting, update devel with Gloo Gateway references (#9646) * devel/ : Gloo Edge -> Gloo Gateway * more changes * update workflows, add go-test-with-coverage * run unit tests on PR * update name * fix coverage file path * consistent step names * disable race to prove out test coverage * add working dir * properly specify outputdir * test coverage update * install test tools * install tools and coverage tools * update thresholds, ignore errors in CI * update test coverage def * add changleog * update commet in gha * re-add race flag * E.T phone home * Apply suggestions from code review Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> * Apply suggestions from code review Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> * more suggestions * skip kube tests --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com> * consolidate changelog * gateway2/deployer: fix race due to context cancellation (#9651) * fix helm race * tidy * update commentary, and function asignautres --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> * cleanup changelog * delete readme, was moved to devel folder --------- Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com> Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io> Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a test flake on the
iosnapshot/history_testContext
Logs of flake: https://storage.googleapis.com/solo-public-build-logs/log-f65eaca6-a7b3-4b7d-9f51-1c65d0b916da.txt
Error:
Internal slack ref: https://solo-io-corp.slack.com/archives/C06C8RA01NF/p1718639733601789
Interesting decisions
Testing steps
To prove the tests work:
To prove the tests are flake-free:
Notes for reviewers
Checklist: