Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.17] backport recent changes to main #9652

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

sam-heilbron
Copy link
Contributor

@sam-heilbron sam-heilbron commented Jun 20, 2024

Description

Backport a few recent commits from the main branch

Context

This is a clean cherry-pick of the following PRs:

Interesting decisions

Testing steps

  • I relied on CI passing

Notes for reviewers

  • These are fairly low-risk changes (small or purely docs changes), so I opted to batch them together in a backport, rather than creating multliple smaller PRs

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

sam-heilbron and others added 3 commits June 20, 2024 12:45
* fix test flake

* add changelog

* skip kube tests

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
* update helm api and docs

* bad .

* more restrictive check

* add test case

* add changelog

* undo debugging step

* update helm api description

* improve helm description

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
…erences (#9646)

* devel/ : Gloo Edge -> Gloo Gateway

* more changes

* update workflows, add go-test-with-coverage

* run unit tests on PR

* update name

* fix coverage file path

* consistent step names

* disable race to prove out test coverage

* add working dir

* properly specify outputdir

* test coverage update

* install test tools

* install tools and coverage tools

* update thresholds, ignore errors in CI

* update test coverage def

* add changleog

* update commet in gha

* re-add race flag

* E.T phone home

* Apply suggestions from code review

Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>

* Apply suggestions from code review

Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>

* more suggestions

* skip kube tests

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
Co-authored-by: Jacob Bohanon <jacob.bohanon@solo.io>
Co-authored-by: Nadine Spies <17709352+Nadine2016@users.noreply.github.com>
@github-actions github-actions bot added the keep pr updated signals bulldozer to keep pr up to date with base branch label Jun 20, 2024
@sam-heilbron sam-heilbron marked this pull request as ready for review June 20, 2024 18:52
@sam-heilbron sam-heilbron requested a review from a team as a code owner June 20, 2024 18:52
sam-heilbron and others added 2 commits June 20, 2024 12:59
* fix helm race

* tidy

* update commentary, and function asignautres

---------

Co-authored-by: soloio-bulldozer[bot] <48420018+soloio-bulldozer[bot]@users.noreply.github.com>
@sam-heilbron
Copy link
Contributor Author

bulldozer

@soloio-bulldozer soloio-bulldozer bot merged commit f18b826 into v1.17.x Jun 20, 2024
18 of 19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the backport/v1.17.x/recent-gg-prs branch June 20, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants