[Dynamic buffer] Updating peer response from a fixed value to dynamically calculating #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change to calculate peer_response at different operating speeds, according to the definition in IEEE 802.3 31B.3.7, instead of taking a fixed number.
Co-authored-by: Stephen Sun <5379172+stephenxs@users.noreply.github.com>
This was referenced Sep 24, 2021
neethajohn
reviewed
Nov 11, 2021
neethajohn
approved these changes
Nov 12, 2021
liat-grozovik
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Nov 15, 2021
…g to the speed (#1930) - What I did Peer response time was deduced from a fixed value for all the ports speed. According to IEEE802.3 31B.3.7 at different operating speeds, the peer response time is also different, to have a more accurate headroom allocation, the way to calculate the peer response time shall be changed accordingly. See HLD update PR sonic-net/SONiC#870 for more info - Why I did it To have the peer response time more accurate, calculate according to the definition in IEEE802.3 31B.3.7 - How I verified it Run buffer regression tests on various Mellanox platforms at various port speeds, cable lengths, with or w/o gearbox.
neethajohn
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Nov 17, 2021
Signed-off-by: Kebo Liu <kebol@nvidia.com> Enhance the buffer test with: * implemented the algorithm to calculate the headroom value based on the input port attributes * for SONiC image version higher than 202106, compare the headroom against the calculated result based on the port attributes, for SONiC image version 202106 and before, keep the old way, comparing the values from pg_profile_lookup.ini What is the motivation for this PR? To make the test more accurate regarding the headroom comparison, on new SONiC versions(later than 202106), use the same algorithm implemented in sonic-swss to calculate the expected headroom values instead of look up the pg_profile_lookup.ini. The relevant SONiC headroom calculation change is described in sonic-net/SONiC#870 How did you do it? * implement the same headroom calculating algorithm as in the sonic-swss. * compare the headroom values against the values calculated by the above new algorithm fruition How did you verify/test it? Run buffer regression test on various Mellanox platform Any platform specific information? This change only impacts the Mellanox platform
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
Signed-off-by: Kebo Liu <kebol@nvidia.com> Enhance the buffer test with: * implemented the algorithm to calculate the headroom value based on the input port attributes * for SONiC image version higher than 202106, compare the headroom against the calculated result based on the port attributes, for SONiC image version 202106 and before, keep the old way, comparing the values from pg_profile_lookup.ini What is the motivation for this PR? To make the test more accurate regarding the headroom comparison, on new SONiC versions(later than 202106), use the same algorithm implemented in sonic-swss to calculate the expected headroom values instead of look up the pg_profile_lookup.ini. The relevant SONiC headroom calculation change is described in sonic-net/SONiC#870 How did you do it? * implement the same headroom calculating algorithm as in the sonic-swss. * compare the headroom values against the values calculated by the above new algorithm fruition How did you verify/test it? Run buffer regression test on various Mellanox platform Any platform specific information? This change only impacts the Mellanox platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to calculate the buffer to handle peer response time according to the operating speed, instead of taking a fixed number. According to the definition in IEEE 802.3 31B.3.7 at different operating speeds, the peer response time is also different. This enhancement is to describes how to calculate the buffer needed to handle the peer response time.