[QoS/test_buffer] [Mellanox] Enhance test_buffer #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 5 alerts and fixes 1 when merging 52ba581 into b724f7a - view on LGTM.com new alerts:
fixed alerts:
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
keboliu
force-pushed
the
peer-response-time
branch
from
52ba581
to
a28792a
Compare
|
This pull request introduces 5 alerts and fixes 1 when merging a28792a into e518208 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Kebo Liu <kebol@nvidia.com>
|
This pull request introduces 5 alerts when merging 21f8a7c into e518208 - view on LGTM.com new alerts:
|
|
@stephenxs could you please review the suggested change? |
stephenxs
reviewed
Oct 13, 2021
Signed-off-by: Kebo Liu <kebol@nvidia.com>
stephenxs
approved these changes
Oct 18, 2021
|
@neethajohn could you please help to review? |
neethajohn
reviewed
Nov 12, 2021
neethajohn
reviewed
Nov 15, 2021
neethajohn
approved these changes
Nov 16, 2021
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
Signed-off-by: Kebo Liu <kebol@nvidia.com> Enhance the buffer test with: * implemented the algorithm to calculate the headroom value based on the input port attributes * for SONiC image version higher than 202106, compare the headroom against the calculated result based on the port attributes, for SONiC image version 202106 and before, keep the old way, comparing the values from pg_profile_lookup.ini What is the motivation for this PR? To make the test more accurate regarding the headroom comparison, on new SONiC versions(later than 202106), use the same algorithm implemented in sonic-swss to calculate the expected headroom values instead of look up the pg_profile_lookup.ini. The relevant SONiC headroom calculation change is described in sonic-net/SONiC#870 How did you do it? * implement the same headroom calculating algorithm as in the sonic-swss. * compare the headroom values against the values calculated by the above new algorithm fruition How did you verify/test it? Run buffer regression test on various Mellanox platform Any platform specific information? This change only impacts the Mellanox platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu kebol@nvidia.com
Description of PR
Summary:
Enhance the buffer test with:
Type of change
Back port request
Approach
What is the motivation for this PR?
To make the test more accurate regarding the headroom comparison, on new SONiC versions(later than 202106), use the same algorithm implemented in sonic-swss to calculate the expected headroom values instead of look up the pg_profile_lookup.ini. The relevant SONiC headroom calculation change is described in sonic-net/SONiC#870
How did you do it?
How did you verify/test it?
Run buffer regression test on various Mellanox platform
Any platform specific information?
This change only impacts the Mellanox platform
Supported testbed topology if it's a new test case?
Documentation