[swss/syncd] remove dependency on interfaces-config.service #13084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
in interfaces-config.sh file, there are some ZTP support which enable dhclient on front panel port as well. from current look, it seems it only try to generate correct /etc/network/interfaces file and restart networking service. i tend to agree that swss and syncd should not have dependency on interfaces-config.service. |
lguohan
approved these changes
Dec 20, 2022
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 15, 2023
…t#13084) - Why I did it Remove dependency on interfaces-config.service to speed up boot, because interfaces-config.service takes a lot of time on boot. - How I did it Changed service files for swss, syncd. - How to verify it Boot and check swss/syncd start time comparing to interfaces-config Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
Cherry-pick PR to 202205: #14252 |
mssonicbld
pushed a commit
that referenced
this pull request
Mar 16, 2023
- Why I did it Remove dependency on interfaces-config.service to speed up boot, because interfaces-config.service takes a lot of time on boot. - How I did it Changed service files for swss, syncd. - How to verify it Boot and check swss/syncd start time comparing to interfaces-config Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
mssonicbld
added
Included in 202205 Branch
and removed
Approved for 202205 Branch
Created PR to 202205 Branch
labels
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 19, 2023
…t#13084) - Why I did it Remove dependency on interfaces-config.service to speed up boot, because interfaces-config.service takes a lot of time on boot. - How I did it Changed service files for swss, syncd. - How to verify it Boot and check swss/syncd start time comparing to interfaces-config Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
Cherry-pick PR to 202211: #14341 |
mssonicbld
added a commit
that referenced
this pull request
Mar 19, 2023
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
8 tasks
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Apr 4, 2023
All these 3 services started after swss service, which used to start after interface-config service. But sonic-net#13084 remove the time constraints for swss. After that, these 3 services has the chance of start earlier when the inteface-config service is restarting the networking service, which could cause db connect request to fail. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
added a commit
that referenced
this pull request
Apr 4, 2023
Why I did it All these 3 services started after swss service, which used to start after interface-config service. But #13084 remove the time constraints for swss. After that, these 3 services has the chance of start earlier when the inteface-config service is restarting the networking service, which could cause db connect request to fail. How I did it Delay mux/sflow/snmp timer after the interface-config service. How to verify it PR test. Config reload can repro the issue in 1-3 retries. With this change. config reload run 30+ iterations without hitting the issue. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 4, 2023
…14506) Why I did it All these 3 services started after swss service, which used to start after interface-config service. But sonic-net#13084 remove the time constraints for swss. After that, these 3 services has the chance of start earlier when the inteface-config service is restarting the networking service, which could cause db connect request to fail. How I did it Delay mux/sflow/snmp timer after the interface-config service. How to verify it PR test. Config reload can repro the issue in 1-3 retries. With this change. config reload run 30+ iterations without hitting the issue. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Apr 20, 2023
…14506) Why I did it All these 3 services started after swss service, which used to start after interface-config service. But sonic-net#13084 remove the time constraints for swss. After that, these 3 services has the chance of start earlier when the inteface-config service is restarting the networking service, which could cause db connect request to fail. How I did it Delay mux/sflow/snmp timer after the interface-config service. How to verify it PR test. Config reload can repro the issue in 1-3 retries. With this change. config reload run 30+ iterations without hitting the issue. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
11 tasks
nazariig
added a commit
to nazariig/sonic-buildimage
that referenced
this pull request
May 16, 2023
…onic-net#13084) (sonic-net#14341)" This reverts commit 499f57a.
9 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
May 17, 2023
nazariig
added a commit
to nazariig/sonic-buildimage
that referenced
this pull request
May 17, 2023
…onic-net#13084)" This reverts commit 661669c.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-buildimage
that referenced
this pull request
Nov 22, 2023
10 tasks
10 tasks
yxieca
pushed a commit
that referenced
this pull request
Dec 7, 2023
Merged
10 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 7, 2023
…onic-net#13084) (sonic-net#14341)" (sonic-net#15094) (sonic-net#17367) This reverts commit 499f57a. Co-authored-by: Nazarii Hnydyn <nazariig@nvidia.com>
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 8, 2023
…onic-net#13084) (sonic-net#14341)" (sonic-net#15094) (sonic-net#17367) This reverts commit 499f57a. Co-authored-by: Nazarii Hnydyn <nazariig@nvidia.com>
Merged
10 tasks
mssonicbld
added a commit
that referenced
this pull request
Dec 8, 2023
mssonicbld
added a commit
that referenced
this pull request
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Why I did it
Remove dependency on interfaces-config.service to speed up boot, because interfaces-config.service takes a lot of time on boot.
How I did it
Changed service files for swss, syncd.
How to verify it
Boot and check swss/syncd start time comparing to interfaces-config
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)