Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: "[swss/syncd] remove dependency on interfaces-config.service" #15091

Closed
wants to merge 1 commit into from

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented May 16, 2023

This reverts #13084

Resolves #15076

Why I did it

  • To stabilize warm/fast reboot
Work item tracking
  • Microsoft ADO (number only):

How I did it

  • Reverted changes

How to verify it

  • Run warm/fast reboot

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Tested branch (Please provide the tested image version)

  • master
  • 202211
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig
Copy link
Collaborator Author

@StormLiangMS can you please assist to merge? The revert was agreed with Ying and Stepan on offline discussion

@nazariig
Copy link
Collaborator Author

@qiluo-msft / @yxieca would you please help to merge?

@yxieca
Copy link
Contributor

yxieca commented May 22, 2023

@qiluo-msft / @yxieca would you please help to merge?

There was an ongoing discussion started by Saikrishna. Please wait for that discussion to close first.

@liat-grozovik
Copy link
Collaborator

@yxieca could you please update on decision moving forward?

@nazariig
Copy link
Collaborator Author

Closing the PR in favour of #15080

@nazariig nazariig closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warm/Fast reboot stability degradation
3 participants