[lldpd]: LLDP changing the tx-interval parameter is not reflected on the peer device immediately #3705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on the peer device immediately
lguohan
reviewed
Nov 5, 2019
| index 8382d02..38cf3f3 100644 | ||
| --- a/src/daemon/client.c | ||
| +++ b/src/daemon/client.c | ||
| @@ -71,7 +71,6 @@ client_handle_set_configuration(struct lldpd *cfg, enum hmsg_type *type, |
There was a problem hiding this comment.
can you add description in the patch itself?
lguohan
reviewed
Nov 5, 2019
| @@ -1,3 +1,4 @@ | |||
| # This series applies on GIT commit 396961a038a38675d46f96eaa7b430b2a1f8701b | |||
| 0001-return-error-when-port-does-not-exist.patch | |||
| 0002-Let-linux-kernel-to-find-appropriate-nl_pid-automa.patch | |||
| 0003-update-tx-interval-immediately.patch | |||
There was a problem hiding this comment.
can you upstream this patch?
There was a problem hiding this comment.
You mean upstream to https://github.com/vincentbernat/lldpd ?
sandeep-kulambi
changed the title
|
Thanks, I see this is fixed in LLDP community - sandeep-kulambi/lldpd@d43d79d#diff-85dc6955b820c3aa562b66089fe99d29
Would like to know how to move forward - will SONiC move to the latest LLDP code base or we want to proceed with this PR ?
Thanks,
Sandeep
|
|
@pavel-shirshov , what is your suggestion? |
|
@lguohan I'd merge this patch for now. |
pavel-shirshov
approved these changes
Nov 7, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…is modified. (sonic-net#3705) When LLDP parameter tx-interval value is modified, there was no immediate PDU sent to peer to update the peer with the latest values. Due to this the update on peer happened only after the next PDU is sent which can cause a delay of upto 30 secs (default value).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
When LLDP parameter tx-interval value is modified, there was no immediate PDU sent to peer to update the peer with the latest values. Due to this the update on peer happened only after the next PDU is sent which can cause a delay of upto 30 secs (default value).
- How I did it
The fix is to ensure the LLDP PDU is sent immediately when the tx-interval configuration is modified.
- How to verify it
Modify LLDP tx-interval on one side and check the "show lldp neighbor" output on the peer device to see if its updated immediately
- Description for the changelog