[lldpd]: LLDP changing the tx-interval parameter is not reflected on the peer device immediately #3705
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| diff --git a/src/daemon/client.c b/src/daemon/client.c | ||
| index 8382d02..38cf3f3 100644 | ||
| --- a/src/daemon/client.c | ||
| +++ b/src/daemon/client.c | ||
| @@ -71,7 +71,6 @@ client_handle_set_configuration(struct lldpd *cfg, enum hmsg_type *type, | ||
| if (CHANGED(c_tx_interval) && config->c_tx_interval != 0) { | ||
| if (config->c_tx_interval < 0) { | ||
| log_debug("rpc", "client asked for immediate retransmission"); | ||
| - levent_send_now(cfg); | ||
| } else { | ||
| log_debug("rpc", "client change transmit interval to %d", | ||
| config->c_tx_interval); | ||
| @@ -79,6 +78,7 @@ client_handle_set_configuration(struct lldpd *cfg, enum hmsg_type *type, | ||
| LOCAL_CHASSIS(cfg)->c_ttl = cfg->g_config.c_tx_interval * | ||
| cfg->g_config.c_tx_hold; | ||
| } | ||
| + levent_send_now(cfg); | ||
| } | ||
| if (CHANGED(c_tx_hold) && config->c_tx_hold > 0) { | ||
| log_debug("rpc", "client change transmit hold to %d", | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| # This series applies on GIT commit 396961a038a38675d46f96eaa7b430b2a1f8701b | ||
| 0001-return-error-when-port-does-not-exist.patch | ||
| 0002-Let-linux-kernel-to-find-appropriate-nl_pid-automa.patch | ||
| 0003-update-tx-interval-immediately.patch | ||
|
There was a problem hiding this comment. can you upstream this patch? There was a problem hiding this comment. You mean upstream to https://github.com/vincentbernat/lldpd ? |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add description in the patch itself?