Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API #11708

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Feb 16, 2024

Description of PR

Since we are now planning to remove "active_firmware" and "inactive_firmware" version fields from TRANSCEIVER_INFO and are replacing it with TRANSCEIVER_FIRMWARE_INFO, we need to add a testcase for get_transceiver_info_firmware_versions API.
Also, we need to remove these fields from the existing testcase for

def test_get_transceiver_info(self, duthosts, enum_rand_one_per_hwsku_hostname, localhost, platform_api_conn):

MSFT ADO - 26818128

Summary:
Fixes # (issue)
This issue should be merged along with sonic-net/sonic-platform-daemons#435 and sonic-net/sonic-platform-common#440

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Ensured that platform_tests/api/test_sfp.py::TestSfpApi::test_get_transceiver_info testcase passes for a CMIS supported transceiver.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…are_versions API

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

tests/common/helpers/platform_api/sfp.py:68:1: E302 expected 2 blank lines, found 1
tests/common/helpers/platform_api/sfp.py:71:1: E302 expected 2 blank lines, found 1
tests/platform_tests/api/test_sfp.py:396:121: E501 line too long (136 > 120 characters)
tests/platform_tests/api/test_sfp.py:397:121: E501 line too long (145 > 120 characters)

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@prgeor prgeor merged commit 92fd2a4 into sonic-net:master Feb 19, 2024
13 checks passed
@prgeor
Copy link
Contributor

prgeor commented Feb 19, 2024

@mihirpat1 please see if master buildimage has the code changes to support this test PR

@mihirpat1
Copy link
Contributor Author

@mihirpat1 please see if master buildimage has the code changes to support this test PR

Confirmed that the master buildimage has the required code changes via
sonic-net/sonic-buildimage#18125
sonic-net/sonic-buildimage#18124

@mihirpat1
Copy link
Contributor Author

@StormLiangMS @yxieca - Can you please help to cherry-pick this to 202205, 202305 and 202311?
MSFT ADO - 26818128

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Feb 21, 2024
…are_versions API (sonic-net#11708)

* Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Addressed pre-commit check issues

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #11749

mssonicbld pushed a commit that referenced this pull request Feb 22, 2024
…are_versions API (#11708)

* Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Addressed pre-commit check issues

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 7, 2024
…are_versions API (sonic-net#11708)

* Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Addressed pre-commit check issues

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #11918

mssonicbld pushed a commit that referenced this pull request Mar 7, 2024
…are_versions API (#11708)

* Modify test_get_transceiver_info to handle get_transceiver_info_firmware_versions API

Signed-off-by: Mihir Patel <patelmi@microsoft.com>

* Addressed pre-commit check issues

---------

Signed-off-by: Mihir Patel <patelmi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants