Change get_transceiver_info_firmware_versions return type to dict #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
8 tasks
prgeor
approved these changes
Feb 16, 2024
|
@StormLiangMS @yxieca - Can you please help to cherry-pick this to 202205, 202305 and 202311? |
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Feb 16, 2024
…nic-net#440) Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
Cherry-pick PR to 202311: #441 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 17, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
8 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-platform-common
that referenced
this pull request
Feb 22, 2024
…nic-net#440) Signed-off-by: Mihir Patel <patelmi@microsoft.com>
|
Cherry-pick PR to 202305: #443 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 22, 2024
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify the return type of
get_transceiver_info_firmware_versionsAPI to dictionary.Also, remove the
active_firmwareandinactive_firmwarefields fromget_transceiver_infosince xcvrd is now using TRANSCEIVER_FIRMWARE_INFO table to store these values.MSFT ADO - 26788561
This PR should be merged along with sonic-net/sonic-platform-daemons#435 and sonic-net/sonic-mgmt#11708.
Motivation and Context
This changeset is required to store
active_firmwareandinactive_firmwarefields to TRANSCEVIER_FIRMWARE_INFO table in xcvrd.How Has This Been Tested?
Please refer to the test result details added in sonic-net/sonic-platform-daemons#435
Additional Information (Optional)