Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IPv6][SNMP]: Remove skip of IPv6 loopback testing #8824

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

SuvarnaMeenakshi
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?

Remove skip of ipv6.

How did you verify/test it?

Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

 ./run_tests.sh -n vms-kvm-t0 -d vlab-01 -c snmp/test_snmp_loopback.py -f vtestbed.yaml -i ../ansible/veos_vtb -e "--skip_sanity --disable_loganalyzer" -u
 ..
 ---------------------------------------------------------------------------------------------------- generated xml file: /data/sonic-mgmt/tests/logs/tr.xml ----------------------------------------------------------------------------------------------------
============================================================================================================ 1 passed, 1 warnings in 25.73 seconds =============================================================================================================
INFO:root:Can not get Allure report URL. Please check logs

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@qiluo-msft
Copy link
Contributor

qiluo-msft commented Jul 5, 2023

# TODO: Fix snmp query over Management IPv6 adderess and add SNMP test over management IPv6 address.

Do you want to remove this TODO?
Do you want add mgmt in the PR title?


In reply to: 1622614016


Refers to: tests/snmp/test_snmp_loopback.py:56 in 384205c. [](commit_id = 384205c, deletion_comment = False)

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
Copy link
Contributor Author

SuvarnaMeenakshi commented Jul 5, 2023

# TODO: Fix snmp query over Management IPv6 adderess and add SNMP test over management IPv6 address.

Do you want to remove this TODO? Do you want add mgmt in the PR title?

Refers to: tests/snmp/test_snmp_loopback.py:56 in 384205c. [](commit_id = 384205c, deletion_comment = False)

Removed comment.

This test specifically tests over loopback IPv4 and IPv6.
I will add another another test to test over mgmt ipv6 or explore enhancing one of the existing test cases to use both mgmt ipv4 and ipv6.

qiluo-msft
qiluo-msft previously approved these changes Jul 5, 2023
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
@SuvarnaMeenakshi
Copy link
Contributor Author

@qiluo-msft can you review this.

@SuvarnaMeenakshi SuvarnaMeenakshi merged commit bcf44a1 into sonic-net:master Jul 26, 2023
13 checks passed
@mssonicbld
Copy link
Collaborator

@SuvarnaMeenakshi PR conflicts with 202205 branch

SuvarnaMeenakshi added a commit to SuvarnaMeenakshi/sonic-mgmt that referenced this pull request Sep 14, 2023
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487

(cherry picked from commit bcf44a1)
wangxin pushed a commit that referenced this pull request Sep 15, 2023
Cherry-pick with conflict resolution of #8824

What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487

(cherry picked from commit bcf44a1)
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants