Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRR] Fixing the advertisement of static ipv6 route #15688

Merged
merged 2 commits into from
Jul 6, 2023
Merged

[FRR] Fixing the advertisement of static ipv6 route #15688

merged 2 commits into from
Jul 6, 2023

Conversation

stepanblyschak
Copy link
Collaborator

@stepanblyschak stepanblyschak commented Jun 30, 2023 •
edited
Loading

Why I did it

To fix an issue - FRRouting/frr#13587

Work item tracking
  • Microsoft ADO (number only):

How I did it

Ported a fix from FRR - FRRouting/frr#13875

How to verify it

Deploy image on T0, verify that Loopback IPv6 network is advertised to arista:

ARISTA01T1>show ipv6 route fc00:1::

VRF: default
Routing entry for fc00:1::
Codes: C - connected, S - static, K - kernel, O3 - OSPFv3, B - BGP, R - RIP, A B - BGP Aggregate, I L1 - IS-IS level 1, I L2 - IS-IS level 2, DH - DHCP, NG - Nexthop Group Static Route, M
- Martian, DP - Dynamic Policy Route, L - VRF Leaked, RC - Route Cache Route

 B        fc00:1::/64 [200/0]
           via fc00::1, Port-Channel1

ARISTA01T1>ping fc00:1::32
PING fc00:1::32(fc00:1::32) 72 data bytes
80 bytes from fc00:1::32: icmp_seq=1 ttl=64 time=1.54 ms
80 bytes from fc00:1::32: icmp_seq=2 ttl=64 time=1.11 ms
80 bytes from fc00:1::32: icmp_seq=3 ttl=64 time=1.17 ms
80 bytes from fc00:1::32: icmp_seq=4 ttl=64 time=1.17 ms
80 bytes from fc00:1::32: icmp_seq=5 ttl=64 time=1.18 ms

--- fc00:1::32 ping statistics ---
5 packets transmitted, 5 received, 0% packet loss, time 5ms
rtt min/avg/max/mdev = 1.117/1.241/1.547/0.155 ms, ipg/ewma 1.428/1.390 ms

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@stepanblyschak stepanblyschak marked this pull request as ready for review July 5, 2023 12:40
@stepanblyschak stepanblyschak mentioned this pull request Jul 5, 2023
Closed
11 tasks
@tjchadaga tjchadaga mentioned this pull request Jul 5, 2023
Closed
@SuvarnaMeenakshi SuvarnaMeenakshi mentioned this pull request Jul 5, 2023
Merged
6 tasks
@liat-grozovik
Copy link
Collaborator

@yxieca as this is a blocker for master warmboot, please help to review/assign someone .

@yxieca yxieca merged commit 6f6218a into sonic-net:master Jul 6, 2023
17 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jul 12, 2023
@stepanblyschak @dgsudharsan
@liat-grozovik @mssonicbld
[FRR]Fixing the advertisement of static ipv6 route (sonic-net#15688)
626ed42 
Co-authored-by: dgsudharsan <sudharsand@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #15802

@mssonicbld mssonicbld mentioned this pull request Jul 12, 2023
Merged
11 tasks
@saiarcot895 saiarcot895 mentioned this pull request Jul 12, 2023
Merged
6 tasks
mssonicbld pushed a commit that referenced this pull request Jul 12, 2023
@stepanblyschak @dgsudharsan
@liat-grozovik @mssonicbld
[FRR]Fixing the advertisement of static ipv6 route (#15688)
8c83dc8 
Co-authored-by: dgsudharsan <sudharsand@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
SuvarnaMeenakshi added a commit to sonic-net/sonic-mgmt that referenced this pull request Jul 26, 2023
@SuvarnaMeenakshi
[IPv6][SNMP]: Remove skip of IPv6 loopback testing (#8824)
bcf44a1 
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487
SuvarnaMeenakshi added a commit to SuvarnaMeenakshi/sonic-mgmt that referenced this pull request Sep 14, 2023
@SuvarnaMeenakshi
[IPv6][SNMP]: Remove skip of IPv6 loopback testing (sonic-net#8824)
d71f382 
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487

(cherry picked from commit bcf44a1)
wangxin pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Sep 15, 2023
@SuvarnaMeenakshi
[IPv6][SNMP]: Remove skip of IPv6 loopback testing (#8824) (#9972)
2ba0f99 
Cherry-pick with conflict resolution of #8824

What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487

(cherry picked from commit bcf44a1)
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@stepanblyschak @dgsudharsan
@liat-grozovik @sonic-otn
[FRR]Fixing the advertisement of static ipv6 route (sonic-net#15688)
17472c2 
Co-authored-by: dgsudharsan <sudharsand@nvidia.com>
Co-authored-by: Liat Grozovik <44433539+liat-grozovik@users.noreply.github.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
@SuvarnaMeenakshi @AharonMalkin
[IPv6][SNMP]: Remove skip of IPv6 loopback testing (sonic-net#8824)
737be3a 
What is the motivation for this PR?
SNMP over Loopback ipv6 is currently being skipped.
sonic-net/sonic-buildimage#15487 -fixes snmp over ipv6.
After the above fix, SNMP over Loopback and management should work.

How did you do it?
Remove skip of ipv6.

How did you verify/test it?
Test on vs testbed with single-asic image with sonic-buildimage 15487 fix.

Prerequisite PRs:
sonic-net/sonic-buildimage#15688
sonic-net/sonic-buildimage#15487
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@yxieca yxieca yxieca approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Approved for 202305 Branch Included in 202305 Branch Request for 202305 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stepanblyschak @liat-grozovik @mssonicbld @dgsudharsan @yxieca @StormLiangMS