Reenable IPv6 BGP neighbor check during warm-reboot #8937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r warm-reboot (sonic-net#8735)" This reverts commit ff4bbf3.
…P doesn't come up (sonic-net#8746)" This reverts commit 5db3a06.
yxieca
approved these changes
Jul 12, 2023
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
* Revert "Temporarily disable checking IPv6 BGP routing on neighbors for warm-reboot (sonic-net#8735)" This reverts commit ff4bbf3. * Revert "Remove the bgp_v6 check, which adds failure since the IPv6 BGP doesn't come up (sonic-net#8746)" This reverts commit 5db3a06.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Now that sonic-net/sonic-buildimage#15688 has been merged, re-enable checking the IPv6 BGP neighbor status during a warm-reboot.
This reverts #8735 and #8746.
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Did a warm-reboot on virtual switch, and verified that it passed.
One oddity that was noticed was that the IPv6 BGP appears to have gone down for about 23 seconds, whereas IPv4 BGP did not go down. This wasn't treated as a failure, though.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation