install numpy<2 in oldestdeps #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
added
the
no-changelog-entry-needed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 69.46% 69.46%
=======================================
Files 24 24
Lines 1634 1634
=======================================
Hits 1135 1135
Misses 499 499 ☔ View full report in Codecov by Sentry. |
zacharyburnett
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy is not a direct dependency and the oldest versions of our dependencies don't pin numpy < 2.0 (and they don't work for numpy 2.0). To allow the oldest deps job to continue to be useful this PR adds a numpy < 2 pin for only the oldest deps job.
See https://github.com/spacetelescope/stpipe/actions/runs/9552146949/job/26328047481?pr=159 for the numerous failures from importing astropy.tables.