Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to sphinx_rtd_theme #159

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jun 17, 2024

Similar to other stsci repos this PR switches the sphinx theme to sphinx_rtd_theme (from stsci_rtd_theme).

See https://stpipe--159.org.readthedocs.build/en/159/api/stpipe.Step.html#stpipe.Step for an example of an improvement with the new theme. The parameters render with a separation between the names and types unlike on main:
https://stpipe.readthedocs.io/en/latest/api/stpipe.Step.html#stpipe.Step

The oldestdeps failure is unrelated, see #158

@braingram braingram added the no-changelog-entry-needed does not require an entry in `CHANGES.rst` label Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.46%. Comparing base (d056adc) to head (46137f0).
Report is 72 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #159   +/-   ##
=======================================
  Coverage   69.46%   69.46%           
=======================================
  Files          24       24           
  Lines        1634     1634           
=======================================
  Hits         1135     1135           
  Misses        499      499           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review June 17, 2024 17:38
@braingram braingram requested a review from a team as a code owner June 17, 2024 17:38
@braingram braingram merged commit 7e4d1bd into spacetelescope:main Jun 18, 2024
16 of 17 checks passed
@braingram braingram deleted the sphinx_theme branch June 18, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-entry-needed does not require an entry in `CHANGES.rst`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants