Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No network preferences short names in addresses of Watch Only Accounts on Share and Share address screens #20166

Open
mariia-skrypnyk opened this issue May 23, 2024 · 2 comments
Open

No network preferences short names in addresses of Watch Only Accounts on Share and Share address screens #20166

mariia-skrypnyk opened this issue May 23, 2024 · 2 comments
Labels
blocked bug wallet: Accounts all issues for the accounts page of the wallet 🔢 low prio

Comments

@mariia-skrypnyk
Copy link

mariia-skrypnyk commented May 23, 2024 •
edited
Loading

Bug Report

Reproduction

  1. Install app
  2. Go to Wallet -> Create Watch only account
  3. Tap Show Address QR code of the account created in step 2

Expected behavior

  1. Watch Only Account's address contains network preferences short names on Share and Share address screens.

  2. These network preference short names should also have the ability to change according to the network preferences set by the user who creates this Watch Only Account.

  3. Eye icon should be present on Share screen

Screenshot 2024-05-23 at 19 44 04

https://www.figma.com/design/xLs1KYmF4e6WwRTZVJKeUK/Descoped-Wallet?node-id=8361-196711

Actual behavior

Screenshot 2024-05-23 at 20 03 07 Screenshot 2024-05-23 at 20 43 14

Additional Information

  • Status version: nightly 23/05
  • Operating System: Android, iOS
@mariia-skrypnyk mariia-skrypnyk added bug E:Mobile Wallet MVP wallet: Accounts all issues for the accounts page of the wallet labels May 23, 2024
@mariia-skrypnyk mariia-skrypnyk changed the title No network preferences short names in addresses of Watch Only Accounts No network preferences short names in addresses of Watch Only Accounts on Share and Share address screens May 23, 2024
@mmilad75 mmilad75 self-assigned this May 27, 2024
This was referenced May 27, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@J-Son89 J-Son89 modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 25, 2024
@J-Son89
Copy link
Contributor

J-Son89 commented Jul 25, 2024

It's likely we remove network preferences feature completely. Let's revisit this for the 2.31 release

This was referenced Jul 25, 2024
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 1, 2024
Merged
Merged
@churik churik added the blocked label Sep 19, 2024
@churik
Copy link
Member

churik commented Sep 19, 2024

Removing from milestone, as network prefixes should be dismissed in the nearest future with simplified wallet flow

@churik churik removed this from the 2.31.0 Beta milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked bug wallet: Accounts all issues for the accounts page of the wallet 🔢 low prio
Projects
Status Desktop/Mobile Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@churik @J-Son89 @mmilad75 @mariia-skrypnyk