Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 'Usage data' bottom sheet reappears after reopening the app if you swipe it down on onboarding #20945

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Parveshdhull
Copy link
Member

@Parveshdhull Parveshdhull commented Aug 1, 2024

fixes #20932

Summary

If the usage data sheet dismissed without input while on boarding, we show that again in profiles screen.
But when we have biometric enabled, we automatically navigate to home screen while still having bottom sheet open. And this caused wrong theme.

In this PR we are delaying automatic login until bottom sheet is dismissed.

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Aug 1, 2024

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ aeaba75 #1 2024-08-01 10:45:49 ~4 min tests 📄log
✔️ aeaba75 #1 2024-08-01 10:48:04 ~6 min android 🤖apk 📲
✔️ aeaba75 #1 2024-08-01 10:48:09 ~6 min android-e2e 🤖apk 📲
✔️ aeaba75 #1 2024-08-01 10:55:35 ~14 min ios 📱ipa 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 27cbaf2 #2 2024-08-01 11:14:39 ~4 min tests 📄log
✔️ 27cbaf2 #2 2024-08-01 11:17:46 ~7 min android-e2e 🤖apk 📲
✔️ 27cbaf2 #2 2024-08-01 11:18:12 ~7 min android 🤖apk 📲
✔️ 27cbaf2 #2 2024-08-01 11:24:20 ~13 min ios 📱ipa 📲
✔️ cab8ee1 #3 2024-08-01 11:42:45 ~5 min tests 📄log
✔️ cab8ee1 #3 2024-08-01 11:46:02 ~8 min android-e2e 🤖apk 📲
✔️ cab8ee1 #3 2024-08-01 11:46:45 ~9 min android 🤖apk 📲
✔️ cab8ee1 #3 2024-08-01 11:50:13 ~12 min ios 📱ipa 📲

Copy link
Contributor

@mohsen-ghafouri mohsen-ghafouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qoqobolo
Copy link
Contributor

qoqobolo commented Aug 1, 2024

@Parveshdhull thanks for the fix!
Would you mind adding to the description the solution you chose, please?
Thank you!

@churik churik self-assigned this Aug 2, 2024
@churik
Copy link
Member

churik commented Aug 2, 2024

Works like a charm on both IOS/Android, waiting for e2e and will be ready

@status-im-auto
Copy link
Member

75% of end-end tests have passed

Total executed tests: 8
Failed tests: 1
Expected to fail tests: 1
Passed tests: 6
IDs of failed tests: 727230 
IDs of expected to fail tests: 727232 

Failed tests (1)

Click to expand
  • Rerun failed tests

  • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230

    Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]`
    Device 2: `Text` is `0.02719 ETH`

    critical/test_wallet.py:190: in test_wallet_send_asset_from_drawer
        self.errors.verify_no_errors()
    base_test_case.py:191: in verify_no_errors
        pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
     Sender balance is not updated on Etherscan, it is 0.4666 but expected to be 0.4667
    



    Expected to fail tests (1)

    Click to expand

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button

    critical/test_wallet.py:274: in test_wallet_add_remove_watch_only_account
        self.home_view.driver.fail(
    base_test_case.py:179: in fail
        pytest.fail('Device %s: %s' % (self.number, text))
     Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae' 
    

    [[Missing networks in account address, https://github.com//issues/20166]]

    Device sessions

    Passed tests (6)

    Click to expand

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestWalletMultipleDevice:

    1. test_wallet_send_eth, id: 727229

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_edit, id: 702843
    Device sessions

    @churik
    Copy link
    Member

    churik commented Aug 2, 2024

    It works like a charm on both platforms, fix totally makes sense to me, thank you!

    @Parveshdhull Parveshdhull merged commit 11bd340 into develop Aug 2, 2024
    5 of 6 checks passed
    @Parveshdhull Parveshdhull deleted the fix/metrics-sheet branch August 2, 2024 09:47
    ilmotta pushed a commit that referenced this pull request Aug 2, 2024
    ilmotta pushed a commit that referenced this pull request Aug 2, 2024
    ilmotta pushed a commit that referenced this pull request Aug 2, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    Archived in project
    6 participants