Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wallet)_: Add beta info box in activity tab #20873

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

smohamedjavid
Copy link
Member

fixes #20861

Summary

This PR adds the beta info box in the activity tab with links to chain explorers.

Platforms

  • Android
  • iOS

Steps to test

  • Open Status
  • Navigate to the Wallet tab
  • Navigate to any of the account's activity
  • Verify the beta info box is shown
  • Verify that tapping the chain explorer name takes the user to the respective chain explorer

status: ready

@status-im-auto
Copy link
Member

status-im-auto commented Jul 24, 2024

Jenkins Builds

Click to see older builds (8)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 909b25f #1 2024-07-24 14:53:40 ~5 min tests 📄log
✔️ 909b25f #1 2024-07-24 14:56:03 ~7 min android-e2e 🤖apk 📲
✔️ 909b25f #1 2024-07-24 14:56:10 ~7 min android 🤖apk 📲
✔️ 909b25f #1 2024-07-24 14:57:46 ~9 min ios 📱ipa 📲
✔️ 968f01f #2 2024-07-25 09:48:00 ~10 min ios 📱ipa 📲
✔️ 968f01f #2 2024-07-25 09:48:08 ~10 min tests 📄log
✔️ 968f01f #2 2024-07-25 09:49:39 ~12 min android 🤖apk 📲
✔️ 968f01f #2 2024-07-25 09:50:10 ~12 min android-e2e 🤖apk 📲
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f4afeda #3 2024-07-25 15:02:41 ~4 min tests 📄log
✔️ f4afeda #3 2024-07-25 15:05:05 ~6 min android-e2e 🤖apk 📲
✔️ f4afeda #3 2024-07-25 15:05:10 ~6 min android 🤖apk 📲
f4afeda #3 2024-07-25 15:09:03 ~10 min ios 📄log
f4afeda #4 2024-07-25 15:09:48 ~12 sec ios 📄log
f4afeda #5 2024-07-25 15:19:23 ~9 min ios 📄log
✔️ 2664ef4 #4 2024-07-25 15:48:24 ~4 min tests 📄log
✔️ 2664ef4 #4 2024-07-25 15:51:17 ~6 min android-e2e 🤖apk 📲
✔️ 2664ef4 #4 2024-07-25 15:51:38 ~7 min android 🤖apk 📲
✔️ 2664ef4 #7 2024-07-25 15:57:48 ~13 min ios 📱ipa 📲

Copy link
Contributor

@ulisesmac ulisesmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@status-im-auto
Copy link
Member

86% of end-end tests have passed

Total executed tests: 7
Failed tests: 0
Expected to fail tests: 1
Passed tests: 6
IDs of expected to fail tests: 727232 

Expected to fail tests (1)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Find `EditBox` by `accessibility id`: `add-address-to-watch`
Device 1: Type `0x8d2413447ff297d30bdc475f6d5cb00254685aae` to `EditBox`

critical/test_wallet.py:249: in test_wallet_add_remove_watch_only_account
    self.wallet_view.add_watch_only_account(address=address_to_watch, account_name=new_account_name)
../views/wallet_view.py:163: in add_watch_only_account
    self.account_has_activity_label.wait_for_visibility_of_element()
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 1: Text by accessibility id:`account-has-activity` is not found on the screen after wait_for_visibility_of_element 

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Passed tests (6)

Click to expand

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
2. test_wallet_send_eth, id: 727229

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions

2. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions

@yevh-berdnyk
Copy link
Contributor

Hi @smohamedjavid, thanks for the PR! Checked on iOS and Android - LGTM

Copy link
Contributor

@J-Son89 J-Son89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing, thank you @smohamedjavid! 🙌

@smohamedjavid smohamedjavid force-pushed the feat/add-beta-message-in-activity-tab branch from 968f01f to f4afeda Compare July 25, 2024 14:58
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
@smohamedjavid smohamedjavid force-pushed the feat/add-beta-message-in-activity-tab branch from f4afeda to 2664ef4 Compare July 25, 2024 15:44
@smohamedjavid smohamedjavid merged commit eae8a65 into develop Jul 25, 2024
6 checks passed
@smohamedjavid smohamedjavid deleted the feat/add-beta-message-in-activity-tab branch July 25, 2024 15:58
ilmotta pushed a commit that referenced this pull request Jul 28, 2024
This commit adds the beta info box with links to chain explorers to the activity tab in the wallet.

Signed-off-by: Mohamed Javid <19339952+smohamedjavid@users.noreply.github.com>
ilmotta added a commit that referenced this pull request Jul 30, 2024
Revisions from develop:

- 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902)
- 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721)
- 8c2d539 Enabling WalletConnect feature flag (#20906)
- 67c83b1 fix(wallet): remove edit routes button in bridging (#20874)
- 11a84ba feat(wallet): disable complex routing (#20901)
- 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846)
- 4586f80 Add toggle in advanced settings for mobile data
- 55c620e fix: create password for small screen (#20645)
- 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862)
- 9065395 chore(settings): Disable telemetry option (#20881)
- d27ab75 fix_:display group message using the new ui (#20787)
- c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683)
- 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845)
- a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888)
- a671c70 fix broken screen and navigation when syncing fails (#20887)
- a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799)
- 2e9fa22 feat: wallet router v2 (#20631)
- 737d8c4 rename sub to fix error when requesting to join community (#20868)
- 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883)
- c1d2d44 perf: Fix app freeze after login (#20729)
- 0fed811 e2e: updated testnet switching and added one test into smoke
- 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854)
- be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875)
- eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873)
- fe54a25 fix: not clearing network & web3-wallet on logout (#20886)
- 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836)
- 2ffbdac WalletConnect show expired toast (#20857)
- 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867)
- ff88049 Fix WalletConnect header alignment on Android (#20860)
- cee2124 WalletConnect no internet edge-cases (#20826)
- 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825)
- 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Activity is not shown
6 participants