Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject wallet-connect request by dragging the modal down #20763

Closed
clauxx opened this issue Jul 16, 2024 · 0 comments · Fixed by #20836
Closed

Reject wallet-connect request by dragging the modal down #20763

clauxx opened this issue Jul 16, 2024 · 0 comments · Fixed by #20836
Assignees
@alwx
Labels
bug dapp-interactions-team
Milestone
2.31.0 Beta

Comments

@clauxx
Copy link
Member

clauxx commented Jul 16, 2024

Bug Report

Problem

Currently when dragging a WalletConnect session-request modal down, the modal is closed but the session request is not rejected. This means that no new session-requests will propagate until the user logs out and in and signs/rejects the request or it expires, as we currently have no way to allow the user to resume a request when ignored.

Expected behavior

The session request is rejected when dragging the modal down

Actual behavior

The session request is ignored when dragging the modal down

Reproduction

  1. Make sure you're connected to a dapp (e.g. https://react-app.walletconnect.com/)
  2. Send any session request (e.g. personal_sign) from the dapp
  3. Drag the "message sign" modal down
  4. Try sending another session request (nothing will be shown until the user finishes the previous request)

Additional Information

  • Status version: nightly
  • Operating System: Android, iOS
@clauxx clauxx added this to the 2.30.0 Beta milestone Jul 16, 2024
@clauxx clauxx self-assigned this Jul 17, 2024
This was referenced Jul 17, 2024
Closed
Merged
@clauxx clauxx removed their assignment Jul 19, 2024
@alwx alwx self-assigned this Jul 22, 2024
alwx added a commit that referenced this issue Jul 22, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
e50569a
@alwx alwx mentioned this issue Jul 22, 2024
Merged
alwx added a commit that referenced this issue Jul 24, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
d4cebd3
alwx added a commit that referenced this issue Jul 24, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
c02680d
alwx added a commit that referenced this issue Jul 24, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
f599b44
alwx added a commit that referenced this issue Jul 24, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
fd9979d
alwx added a commit that referenced this issue Jul 25, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
b66d8cd
@churik churik modified the milestones: 2.30.0 Beta, 2.31.0 Beta Jul 25, 2024
alwx added a commit that referenced this issue Jul 25, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763)
71d73a0
alwx added a commit that referenced this issue Jul 25, 2024
@alwx
Reject wallet-connect request by dragging the modal down (#20763) (#2…
15a4219 
…0836)

* Reject wallet-connect request by dragging the modal down (#20763)

* Fix
ilmotta pushed a commit that referenced this issue Jul 28, 2024
@alwx @ilmotta
Reject wallet-connect request by dragging the modal down (#20763) (#2…
ade608b 
…0836)

* Reject wallet-connect request by dragging the modal down (#20763)

* Fix
ilmotta added a commit that referenced this issue Jul 30, 2024
@ilmotta
Update release branch 2.30.x (#20903)
0f15c01 
Revisions from develop:

- 59ceddb develop origin/develop fix(wallet): fix bridge transactions (#20902)
- 99ccbc3 Cover wallet send events with tests Part 2 #20411 #20533 (#20721)
- 8c2d539 Enabling WalletConnect feature flag (#20906)
- 67c83b1 fix(wallet): remove edit routes button in bridging (#20874)
- 11a84ba feat(wallet): disable complex routing (#20901)
- 1f5bb57 chore(wallet): disable bridging on unsupported tokens (#20846)
- 4586f80 Add toggle in advanced settings for mobile data
- 55c620e fix: create password for small screen (#20645)
- 525609f Wallet Activity: transactions are not sorted by time #20808 (#20862)
- 9065395 chore(settings): Disable telemetry option (#20881)
- d27ab75 fix_:display group message using the new ui (#20787)
- c6a1db6 ci: enable split apks & build only for arm64-v8a (#20683)
- 73777e0 Ensure keycard account can send transaction after upgrading from v1 to v2 #20552 (#20845)
- a6d3fc3 [#20524] fix: the missed keypairs are shown in the key pair list screen (#20888)
- a671c70 fix broken screen and navigation when syncing fails (#20887)
- a45991b 🥅 Filter connected dapps based on testnet mode, reject proposals and requests gracefully (#20799)
- 2e9fa22 feat: wallet router v2 (#20631)
- 737d8c4 rename sub to fix error when requesting to join community (#20868)
- 3aa7e10 Sync process is blocked on Enabled notifications screen (#20883)
- c1d2d44 perf: Fix app freeze after login (#20729)
- 0fed811 e2e: updated testnet switching and added one test into smoke
- 53c35cb fix(wallet): Linear gradient exception on invalid colors for watched account cards (#20854)
- be82365 chore(settings)_: Remove testnet toggle from legacy advanced settings (#20875)
- eae8a65 feat(wallet)_: Add beta info box in activity tab (#20873)
- fe54a25 fix: not clearing network & web3-wallet on logout (#20886)
- 15a4219 Reject wallet-connect request by dragging the modal down (#20763) (#20836)
- 2ffbdac WalletConnect show expired toast (#20857)
- 402eb83 fix Issue with scrolling WalletConnect transaction on Android (#20867)
- ff88049 Fix WalletConnect header alignment on Android (#20860)
- cee2124 WalletConnect no internet edge-cases (#20826)
- 60ad7c8 chore(tests): New match-strict? cljs.test directive (#20825)
- 4989c92 fix_: Adding own address as saved addresses (#20839)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alwx alwx

Labels
bug dapp-interactions-team
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.31.0 Beta
3 participants
@alwx @churik @clauxx