fix bottom message hidden behind composer with minimized keyboard when replying to message #20371

Parveshdhull · 2024-06-06T09:18:28Z

fixes #20307

Testing

Please test last message with all, edit, reply, image, link etc.

status: ready

status-im-auto · 2024-06-06T09:22:55Z

Jenkins Builds

Click to see older builds (15)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`8950ecc`	#1	2024-06-06 09:22:54	~4 min	`tests`	📄`log`
✔️	`8950ecc`	#1	2024-06-06 09:26:09	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`8950ecc`	#1	2024-06-06 09:26:21	~7 min	`android`	🤖`apk` 📲
✔️	`8950ecc`	#1	2024-06-06 09:30:32	~11 min	`ios`	📱`ipa` 📲

✔️	`39d15f1`	#2	2024-06-06 10:29:44	~3 min	`tests`	📄`log`
✔️	`39d15f1`	#2	2024-06-06 10:31:46	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`39d15f1`	#2	2024-06-06 10:32:22	~6 min	`android`	🤖`apk` 📲

✔️	`cc76e30`	#3	2024-06-06 10:39:10	~4 min	`tests`	📄`log`
✔️	`cc76e30`	#3	2024-06-06 10:42:19	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`cc76e30`	#3	2024-06-06 10:42:24	~7 min	`android`	🤖`apk` 📲
✔️	`cc76e30`	#3	2024-06-06 10:45:26	~10 min	`ios`	📱`ipa` 📲

✔️	`3a96b2b`	#4	2024-06-10 10:51:53	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`3a96b2b`	#4	2024-06-10 10:51:59	~7 min	`tests`	📄`log`
✔️	`3a96b2b`	#4	2024-06-10 10:53:36	~9 min	`android`	🤖`apk` 📲
✔️	`3a96b2b`	#4	2024-06-10 10:54:47	~10 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`7a9ec70`	#5	2024-06-11 10:14:19	~5 min	`tests`	📄`log`
✔️	`7a9ec70`	#5	2024-06-11 10:15:35	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`7a9ec70`	#5	2024-06-11 10:16:36	~7 min	`android`	🤖`apk` 📲
✔️	`7a9ec70`	#5	2024-06-11 10:19:40	~10 min	`ios`	📱`ipa` 📲

✔️	`50534a1`	#6	2024-06-13 11:01:17	~4 min	`tests`	📄`log`
✔️	`50534a1`	#6	2024-06-13 11:03:16	~6 min	`android`	🤖`apk` 📲
✔️	`50534a1`	#6	2024-06-13 11:03:57	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`50534a1`	#6	2024-06-13 11:13:44	~17 min	`ios`	📱`ipa` 📲

src/status_im/contexts/chat/messenger/messages/list/view.cljs

status-im-auto · 2024-06-06T11:50:42Z

84% of end-end tests have passed

Total executed tests: 51
Failed tests: 5
Expected to fail tests: 3
Passed tests: 43
Not executed tests: 1

IDs of not executed tests: 702936

IDs of failed tests: 727230,702948,704615,727229,703629

IDs of expected to fail tests: 703495,703503,727232

Not executed tests (1)

Click to expand

Rerun not executed tests

Failed tests (5)

Click to expand

Rerun failed tests

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'#cats')]` Device 2: Looking for a message by text: it is just a message text `critical/chats/test_public_chat_browsing.py:1098: in test_community_hashtag_links_to_community_channels self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message in community channel is not visible for user before join` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_join_when_node_owner_offline, id: 703629
Device 2: Looking for community: 'open community' Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented `critical/chats/test_public_chat_browsing.py:1184: in test_community_join_when_node_owner_offline self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) not` Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
# STEP: Getting ETH amount in the wallet of the sender before transaction Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` critical/test_wallet.py:120: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:41: in _get_balances_before_tx self.wallet_1.wallet_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Tap on found: LogInButton Device 1: Find `Button` by `accessibility id`: `done` critical/test_wallet.py:111: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:100: in send_asset self.confirm_transaction() ../views/wallet_view.py:88: in confirm_transaction self.done_button.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestCommunityMultipleDeviceMerged:

1. test_community_edit_delete_message_when_offline, id: 704615

# STEP: Receiver is checking if initial messages were delivered
Device 1: Looking for a message by text: message to edit

critical/chats/test_public_chat_browsing.py:787: in test_community_edit_delete_message_when_offline
    self.channel_1.driver.fail("Message '%s' was not received" % message)
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Message 'message to edit' was not received

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Expected to fail tests (3)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_watch_only_account, id: 727232

Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
Device 1: Click system back button

critical/test_wallet.py:214: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'

[[Missing networks in account address, https://github.com//issues/20166]]

Device sessions

Device 1:

Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Passed tests (43)

Click to expand

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

pavloburykh · 2024-06-10T12:56:06Z

@Parveshdhull thanks for the PR. Please, take a look at the issues.

ISSUE 1 Bottom message is still partially hidden behind composer on IOS

IOS:

Android: on Android message still located to close to composer

pavloburykh · 2024-06-10T12:56:17Z

ISSUE 2 Space between messages became too large on Android

Reproduced on Android 12, Samsung Galaxy A52

Actual result:

Expected result:

pavloburykh · 2024-06-10T12:56:21Z

ISSUE 3 Wrong opacity of the top edge of composer after editing message

Not sure if it is PR related. Similar issues with opacity are reproducible in nightly, but looks like they have been partially fixed in this PR except current issue. @Parveshdhull I can log separately depending on your decision.

Steps:

Start editing multiline message
Quit editing by tapping [x] button
Pay attention at composer opacity

Actual result: top edge of composer has wrong opacity

telegram-cloud-document-2-5420261835792206715.mp4

Parveshdhull · 2024-06-11T10:16:43Z

hi @pavloburykh, Thank you very much for testing the PR and finding these issues.

Issue 1: This issue happened because of the multi-line message. When we closed the composer with the multi-line message, the composer collapsed with increased height for showing two lines (instead of one) and this was causing overlap. So to fix this, we have to increase the margin of the last message from the composer for multi-line messages. I tried to add this margin when the composer was closing with a multi-line message. But this sudden change in the margin of the last message gave a little jumpy transition. So currently I am adding this margin to the last message as soon as composer input has more than 1 line. Please let me know if this looks ok or needs to be improved.

Issue 2: It was not reproducible by me, still this one doesn't look related to PR. Please let me know if it is still happening in the new build and not in develop. We can try reverting all commits in PR and see if it gets fixed.

Issue 3: Should be fixed now.

pavloburykh · 2024-06-12T14:37:02Z

hi @pavloburykh, Thank you very much for testing the PR and finding these issues.

Issue 1: This issue happened because of the multi-line message. When we closed the composer with the multi-line message, the composer collapsed with increased height for showing two lines (instead of one) and this was causing overlap. So to fix this, we have to increase the margin of the last message from the composer for multi-line messages. I tried to add this margin when the composer was closing with a multi-line message. But this sudden change in the margin of the last message gave a little jumpy transition. So currently I am adding this margin to the last message as soon as composer input has more than 1 line. Please let me know if this looks ok or needs to be improved.

Issue 2: It was not reproducible by me, still this one doesn't look related to PR. Please let me know if it is still happening in the new build and not in develop. We can try reverting all commits in PR and see if it gets fixed.

Issue 3: Should be fixed now.

Thanx for the fixes @Parveshdhull! Sorry for testing delay, I have missed this comment and noticed it just now. Will test the fixes tomorrow and provide and updated.

pavloburykh · 2024-06-13T10:51:50Z

@Parveshdhull thank you! All 3 issues are fixed. Ready for merge.

…n replying to message

Parveshdhull self-assigned this Jun 6, 2024

Parveshdhull added the request-manual-qa label Jun 6, 2024

Parveshdhull requested review from clauxx and OmarBasem June 6, 2024 09:18

clauxx reviewed Jun 6, 2024

View reviewed changes

src/status_im/contexts/chat/messenger/messages/list/view.cljs Outdated Show resolved Hide resolved

flexsurfer approved these changes Jun 6, 2024

View reviewed changes

src/status_im/contexts/chat/messenger/messages/list/view.cljs Outdated Show resolved Hide resolved

clauxx approved these changes Jun 6, 2024

View reviewed changes

OmarBasem approved these changes Jun 7, 2024

View reviewed changes

pavloburykh self-assigned this Jun 10, 2024

pavloburykh force-pushed the fix/last-message-overlap branch from cc76e30 to 3a96b2b Compare June 10, 2024 10:44

pavloburykh added the Tested - Issues label Jun 10, 2024

Parveshdhull force-pushed the fix/last-message-overlap branch from 3a96b2b to 7a9ec70 Compare June 11, 2024 10:09

fix bottom message hidden behind composer with minimised keyboard whe…

50534a1

…n replying to message

Parveshdhull force-pushed the fix/last-message-overlap branch from 7a9ec70 to 50534a1 Compare June 13, 2024 10:56

Parveshdhull merged commit 5f7d725 into develop Jun 13, 2024
6 checks passed

Parveshdhull deleted the fix/last-message-overlap branch June 13, 2024 11:18

Parveshdhull removed the Tested - Issues label Jun 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix bottom message hidden behind composer with minimized keyboard when replying to message #20371

fix bottom message hidden behind composer with minimized keyboard when replying to message #20371

Parveshdhull commented Jun 6, 2024

status-im-auto commented Jun 6, 2024 •

edited

Loading

status-im-auto commented Jun 6, 2024

Class TestCommunityMultipleDeviceMergedTwo:

Class TestWalletMultipleDevice:

Class TestCommunityMultipleDeviceMerged:

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestDeepLinksOneDevice:

Class TestWalletOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Jun 10, 2024

pavloburykh commented Jun 10, 2024

pavloburykh commented Jun 10, 2024

Parveshdhull commented Jun 11, 2024

pavloburykh commented Jun 12, 2024

pavloburykh commented Jun 13, 2024

fix bottom message hidden behind composer with minimized keyboard when replying to message #20371

fix bottom message hidden behind composer with minimized keyboard when replying to message #20371

Conversation

Parveshdhull commented Jun 6, 2024

Testing

status-im-auto commented Jun 6, 2024 • edited Loading

Jenkins Builds

status-im-auto commented Jun 6, 2024

84% of end-end tests have passed

Not executed tests (1)

Failed tests (5)

Class TestCommunityMultipleDeviceMergedTwo:

Class TestWalletMultipleDevice:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (3)

Class TestWalletOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Passed tests (43)

Class TestDeepLinksOneDevice:

Class TestWalletOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePRTwo:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityOneDeviceMerged:

pavloburykh commented Jun 10, 2024

ISSUE 1 Bottom message is still partially hidden behind composer on IOS

pavloburykh commented Jun 10, 2024

ISSUE 2 Space between messages became too large on Android

pavloburykh commented Jun 10, 2024

ISSUE 3 Wrong opacity of the top edge of composer after editing message

Parveshdhull commented Jun 11, 2024

pavloburykh commented Jun 12, 2024

pavloburykh commented Jun 13, 2024

status-im-auto commented Jun 6, 2024 •

edited

Loading